Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nbstore): improve nbstore #9512

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Jan 3, 2025

No description provided.

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:env app:electron Related to electron app test Related to test cases rust mod:native labels Jan 3, 2025
Copy link
Member Author

EYHN commented Jan 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@EYHN EYHN marked this pull request as ready for review January 3, 2025 12:44
@EYHN EYHN requested a review from a team as a code owner January 3, 2025 12:44
@EYHN EYHN force-pushed the eyhn/feat/improve-nbstore branch from 3e2cbdd to 924bcf5 Compare January 3, 2025 12:49
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 45.07576% with 145 lines in your changes missing coverage. Please review.

Project coverage is 52.80%. Comparing base (2074bda) to head (30617ef).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/nbstore/src/frontend/doc.ts 6.45% 58 Missing ⚠️
packages/common/nbstore/src/sync/doc/peer.ts 35.48% 18 Missing and 2 partials ⚠️
packages/common/nbstore/src/sync/blob/index.ts 32.00% 17 Missing ⚠️
packages/common/nbstore/src/sync/doc/index.ts 30.00% 14 Missing ⚠️
packages/common/nbstore/src/storage/dummy/sync.ts 9.09% 10 Missing ⚠️
packages/common/nbstore/src/storage/dummy/doc.ts 30.00% 7 Missing ⚠️
packages/common/nbstore/src/storage/doc.ts 72.22% 1 Missing and 4 partials ⚠️
packages/common/nbstore/src/storage/dummy/blob.ts 33.33% 4 Missing ⚠️
packages/common/env/src/ua-helper.ts 0.00% 1 Missing and 1 partial ⚠️
...ages/common/nbstore/src/storage/dummy/awareness.ts 33.33% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9512      +/-   ##
==========================================
- Coverage   52.85%   52.80%   -0.05%     
==========================================
  Files        2151     2156       +5     
  Lines       96989    97107     +118     
  Branches    16154    16178      +24     
==========================================
+ Hits        51264    51278      +14     
- Misses      44330    44460     +130     
+ Partials     1395     1369      -26     
Flag Coverage Δ
server-test 78.07% <ø> (ø)
unittest 32.41% <45.07%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/feat/improve-nbstore branch from 924bcf5 to 30617ef Compare January 3, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app mod:env mod:infra Environment related issues and discussions mod:native rust test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant