Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): new worker workspace engine #9257

Draft
wants to merge 1 commit into
base: eyhn/feat/improve-nbstore
Choose a base branch
from

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 23, 2024

No description provided.

Copy link
Member Author

EYHN commented Dec 23, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 36.14865% with 189 lines in your changes missing coverage. Please review.

Project coverage is 51.10%. Comparing base (be387a6) to head (ddc7318).
Report is 9 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/nbstore/src/frontend/doc.ts 6.45% 58 Missing ⚠️
...tend/core/src/modules/workspace/entities/engine.ts 0.00% 22 Missing ⚠️
packages/common/nbstore/src/sync/doc/peer.ts 35.48% 18 Missing and 2 partials ⚠️
packages/common/nbstore/src/sync/blob/index.ts 32.00% 17 Missing ⚠️
packages/common/nbstore/src/sync/doc/index.ts 30.00% 14 Missing ⚠️
packages/common/nbstore/src/storage/dummy/sync.ts 9.09% 10 Missing ⚠️
packages/common/nbstore/src/storage/dummy/doc.ts 30.00% 7 Missing ⚠️
...d/core/src/modules/workspace/services/transform.ts 0.00% 7 Missing ⚠️
...ckages/frontend/core/src/modules/db/services/db.ts 0.00% 6 Missing ⚠️
...d/core/src/modules/workspace/entities/workspace.ts 0.00% 6 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9257      +/-   ##
==========================================
- Coverage   52.62%   51.10%   -1.53%     
==========================================
  Files        2151     2154       +3     
  Lines       96918    97013      +95     
  Branches    16145    16154       +9     
==========================================
- Hits        51000    49574    -1426     
- Misses      44507    45691    +1184     
- Partials     1411     1748     +337     
Flag Coverage Δ
server-test 78.14% <ø> (ø)
unittest 30.43% <36.14%> (-2.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/feat/worker-engine branch from 0d82090 to 7cad7ab Compare December 27, 2024 16:15
@github-actions github-actions bot added the mod:i18n Related to i18n label Dec 27, 2024
@EYHN EYHN force-pushed the eyhn/feat/worker-engine branch from 7cad7ab to 166306c Compare December 30, 2024 02:23
@github-actions github-actions bot added mod:infra Environment related issues and discussions app:electron Related to electron app test Related to test cases labels Dec 30, 2024
@EYHN EYHN force-pushed the eyhn/feat/worker-engine branch 3 times, most recently from f606157 to ddc7318 Compare January 2, 2025 12:16
@EYHN EYHN force-pushed the eyhn/feat/worker-engine branch from d046658 to dd2a68e Compare January 3, 2025 12:44
@EYHN EYHN changed the base branch from canary to eyhn/feat/improve-nbstore January 3, 2025 12:44
@EYHN EYHN force-pushed the eyhn/feat/improve-nbstore branch from 3e2cbdd to 924bcf5 Compare January 3, 2025 12:49
@EYHN EYHN force-pushed the eyhn/feat/worker-engine branch from dd2a68e to ece77f6 Compare January 3, 2025 12:49
@EYHN EYHN force-pushed the eyhn/feat/improve-nbstore branch from 924bcf5 to 30617ef Compare January 3, 2025 14:26
@EYHN EYHN force-pushed the eyhn/feat/worker-engine branch from ece77f6 to b7abb56 Compare January 3, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:env mod:i18n Related to i18n mod:infra Environment related issues and discussions mod:native rust test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant