Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): split view solo view crash #9432

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Dec 30, 2024

No description provided.

@pengx17 pengx17 marked this pull request as ready for review December 30, 2024 10:29
Copy link
Collaborator Author

pengx17 commented Dec 30, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 force-pushed the 12-30-fix_core_split_view_solo_view_crash branch from bcbad8e to ecd06b4 Compare December 30, 2024 10:31
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.65%. Comparing base (397a483) to head (79e0064).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9432      +/-   ##
==========================================
- Coverage   51.68%   51.65%   -0.03%     
==========================================
  Files        2152     2152              
  Lines       97009    97009              
  Branches    16205    16205              
==========================================
- Hits        50135    50113      -22     
- Misses      45511    45554      +43     
+ Partials     1363     1342      -21     
Flag Coverage Δ
server-test 78.07% <ø> (-0.07%) ⬇️
unittest 31.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 12-30-fix_core_split_view_solo_view_crash branch from ecd06b4 to 10e58bd Compare December 30, 2024 16:40
Copy link

graphite-app bot commented Dec 30, 2024

Merge activity

@pengx17 pengx17 force-pushed the 12-30-fix_core_split_view_solo_view_crash branch from 10e58bd to 79e0064 Compare December 30, 2024 16:54
@graphite-app graphite-app bot merged commit 79e0064 into canary Dec 30, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-30-fix_core_split_view_solo_view_crash branch December 30, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants