fix(core): split view solo view crash

toeverything · Dec 30, 2024 · bcbad8e · bcbad8e
1 parent 6977b0a
commit bcbad8e
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/packages/frontend/core/src/modules/workbench/entities/workbench.ts b/packages/frontend/core/src/modules/workbench/entities/workbench.ts
@@ -43,8 +43,10 @@ export class Workbench extends Entity {
   activeView$ = LiveData.computed(get => {
     const activeIndex = get(this.activeViewIndex$);
     const views = get(this.views$);
-    return views[activeIndex]; // todo: this could be null
+    // activeIndex could be out of bounds when reordering views
+    return views.at(activeIndex) || views[0];
   });
+
   location$ = LiveData.computed(get => {
     return get(get(this.activeView$).location$);
   });
@@ -127,9 +129,9 @@ export class Workbench extends Entity {
     id:
       | string
       | ({ docId: string } & (
-          | ReferenceParams
-          | Record<string, string | undefined>
-        )),
+        | ReferenceParams
+        | Record<string, string | undefined>
+      )),
     options?: WorkbenchOpenOptions
   ) {
     const isString = typeof id === 'string';