Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: find in page #7086

Merged
merged 1 commit into from
May 28, 2024
Merged

refactor: find in page #7086

merged 1 commit into from
May 28, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 27, 2024

  • refactor rxjs data flow
  • use canvas text to mitigate searchable search box input text issue

Copy link

graphite-app bot commented May 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented May 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented May 27, 2024

@pengx17 pengx17 requested a review from JimmFly May 27, 2024 16:18
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 5.71429% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 66.98%. Comparing base (bd9c929) to head (2ca77d9).

Files Patch % Lines
.../src/modules/find-in-page/entities/find-in-page.ts 4.00% 24 Missing ⚠️
packages/frontend/component/src/ui/input/input.tsx 0.00% 8 Missing ⚠️
packages/frontend/component/src/ui/modal/modal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7086      +/-   ##
==========================================
+ Coverage   66.92%   66.98%   +0.05%     
==========================================
  Files         592      592              
  Lines       28947    28950       +3     
  Branches     2611     2616       +5     
==========================================
+ Hits        19374    19392      +18     
+ Misses       9300     9285      -15     
  Partials      273      273              
Flag Coverage Δ
server-test 77.65% <ø> (+0.08%) ⬆️
unittest 39.01% <5.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JimmFly JimmFly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@pengx17 pengx17 force-pushed the xp/05-28-refactor_find_in_page branch from 60fe03a to 99d1948 Compare May 28, 2024 02:37
@pengx17 pengx17 marked this pull request as ready for review May 28, 2024 05:46
Copy link

graphite-app bot commented May 28, 2024

Merge activity

- refactor rxjs data flow
- use canvas text to mitigate searchable search box input text issue
@pengx17 pengx17 force-pushed the jimmfly/0523/cmd-f branch from 350e4a7 to bd9c929 Compare May 28, 2024 06:20
@pengx17 pengx17 force-pushed the xp/05-28-refactor_find_in_page branch from 99d1948 to 2ca77d9 Compare May 28, 2024 06:21
@pengx17 pengx17 changed the base branch from jimmfly/0523/cmd-f to canary May 28, 2024 06:31
@graphite-app graphite-app bot merged commit 2ca77d9 into canary May 28, 2024
32 checks passed
@graphite-app graphite-app bot deleted the xp/05-28-refactor_find_in_page branch May 28, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants