Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): cmd+f search in doc function #7040

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 23, 2024

close AFF-250
You can use the cmd+F shortcut key to trigger the FindInPage function.

Copy link

graphite-app bot commented May 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added app:electron Related to electron app app:core labels May 23, 2024
Copy link
Member Author

JimmFly commented May 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented May 23, 2024

@JimmFly JimmFly changed the title feat(core): init cmd+f in-text search function feat(core): cmd+f search in doc function May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 8.16327% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 66.92%. Comparing base (5759c15) to head (bd9c929).

Files Patch % Lines
.../src/modules/find-in-page/entities/find-in-page.ts 0.00% 43 Missing ⚠️
.../src/modules/find-in-page/services/find-in-page.ts 0.00% 1 Missing ⚠️
.../core/src/modules/right-sidebar/view/container.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7040      +/-   ##
==========================================
- Coverage   67.04%   66.92%   -0.12%     
==========================================
  Files         589      592       +3     
  Lines       28899    28947      +48     
  Branches     2604     2611       +7     
==========================================
- Hits        19376    19374       -2     
- Misses       9250     9300      +50     
  Partials      273      273              
Flag Coverage Δ
server-test 77.56% <ø> (ø)
unittest 39.03% <8.16%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/0523/cmd-f branch from b0cd32e to e291c51 Compare May 23, 2024 09:43
@JimmFly JimmFly requested review from EYHN and pengx17 May 23, 2024 09:48
@JimmFly JimmFly force-pushed the jimmfly/0523/cmd-f branch 3 times, most recently from 9f3598b to 23201c0 Compare May 27, 2024 06:46
@JimmFly JimmFly requested a review from pengx17 May 27, 2024 06:49
@pengx17 pengx17 force-pushed the jimmfly/0523/cmd-f branch from 23201c0 to 350e4a7 Compare May 27, 2024 16:16
@pengx17 pengx17 mentioned this pull request May 27, 2024
@JimmFly JimmFly marked this pull request as ready for review May 28, 2024 04:52
Copy link

graphite-app bot commented May 28, 2024

Merge activity

You can use the cmd+F shortcut key to trigger the FindInPage function.
@pengx17 pengx17 force-pushed the jimmfly/0523/cmd-f branch from 350e4a7 to bd9c929 Compare May 28, 2024 06:20
@graphite-app graphite-app bot merged commit bd9c929 into canary May 28, 2024
32 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0523/cmd-f branch May 28, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants