Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch service syntax #7080

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 27, 2024

Not sure if there is a better pattern like "macros" that can make this more generic. 🤡

also added notify impl to notification service for bs
toeverything/blocksuite#7160

Copy link

graphite-app bot commented May 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 marked this pull request as ready for review May 27, 2024 09:12
Copy link
Collaborator Author

pengx17 commented May 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented May 27, 2024

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (622239f) to head (da3cbc6).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7080   +/-   ##
=======================================
  Coverage   67.25%   67.25%           
=======================================
  Files         612      612           
  Lines       29860    29860           
  Branches     2683     2683           
=======================================
  Hits        20082    20082           
  Misses       9503     9503           
  Partials      275      275           
Flag Coverage Δ
server-test 77.57% <ø> (ø)
unittest 39.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/05-27-fix_patch_service_syntax branch 3 times, most recently from bbee60c to a202276 Compare May 28, 2024 10:40
@pengx17 pengx17 force-pushed the xp/05-27-fix_patch_service_syntax branch from a202276 to 52f755c Compare May 29, 2024 03:10
@pengx17 pengx17 force-pushed the xp/05-27-fix_patch_service_syntax branch from 52f755c to 40697f5 Compare May 30, 2024 05:30
@pengx17 pengx17 mentioned this pull request May 30, 2024
@pengx17 pengx17 force-pushed the xp/05-27-fix_patch_service_syntax branch from 40697f5 to ca1e2f3 Compare May 30, 2024 09:39
@Saul-Mirone
Copy link
Contributor

in fact we have a spec provider which can help to build specs...

Copy link
Collaborator Author

pengx17 commented May 30, 2024

in fact we have a spec provider which can help to build specs...

Can you please give me an example?

Copy link

graphite-app bot commented May 30, 2024

Merge activity

Not sure if there is a better pattern like "macros" that can make this more generic. 🤡

also added notify impl to notification service for bs
toeverything/blocksuite#7160
@pengx17 pengx17 force-pushed the xp/05-27-fix_patch_service_syntax branch from ca1e2f3 to da3cbc6 Compare May 30, 2024 11:46
@graphite-app graphite-app bot merged commit da3cbc6 into canary May 30, 2024
32 checks passed
@graphite-app graphite-app bot deleted the xp/05-27-fix_patch_service_syntax branch May 30, 2024 14:33
Copy link

sentry-io bot commented Jun 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RangeError: Maximum call stack size exceeded / View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants