Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: center peek view #7073

Merged
merged 1 commit into from
May 31, 2024
Merged

feat: center peek view #7073

merged 1 commit into from
May 31, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented May 26, 2024

🎥 Video uploaded on Graphite:

Copy link

graphite-app bot commented May 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented May 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:core labels May 26, 2024
Copy link

nx-cloud bot commented May 26, 2024

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 15.00000% with 187 lines in your changes are missing coverage. Please review.

Project coverage is 32.04%. Comparing base (b65c01c) to head (ea0059f).

Files Patch % Lines
.../core/src/modules/peek-view/view/doc-peek-view.tsx 5.66% 50 Missing ⚠️
...d/core/src/modules/peek-view/entities/peek-view.ts 8.88% 41 Missing ⚠️
...e/src/modules/peek-view/view/doc-peek-controls.tsx 8.00% 23 Missing ⚠️
...ore/src/modules/peek-view/view/modal-container.tsx 23.07% 20 Missing ⚠️
.../frontend/core/src/modules/peek-view/view/utils.ts 5.26% 18 Missing ⚠️
...e/src/modules/peek-view/view/peek-view-manager.tsx 15.38% 11 Missing ⚠️
...ore/src/components/affine/reference-link/index.tsx 0.00% 9 Missing ⚠️
...e/block-suite-editor/specs/custom/spec-patchers.ts 10.00% 9 Missing ⚠️
...nents/blocksuite/block-suite-editor/lit-adaper.tsx 0.00% 2 Missing ⚠️
...d/core/src/modules/peek-view/services/peek-view.ts 33.33% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7073       +/-   ##
===========================================
- Coverage   67.31%   32.04%   -35.27%     
===========================================
  Files         612      595       -17     
  Lines       29863    11933    -17930     
  Branches     2684     2057      -627     
===========================================
- Hits        20102     3824    -16278     
+ Misses       9486     7878     -1608     
+ Partials      275      231       -44     
Flag Coverage Δ
server-test ?
unittest 32.04% <15.00%> (-7.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn force-pushed the xp/05-26-build_enable_new_decorator_for_swc branch from 36fb018 to 13b51c7 Compare May 27, 2024 05:22
@Brooooooklyn Brooooooklyn changed the base branch from xp/05-26-build_enable_new_decorator_for_swc to canary May 27, 2024 05:32
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch 3 times, most recently from 35ec701 to 604ff28 Compare May 30, 2024 05:30
@pengx17 pengx17 changed the base branch from canary to xp/05-27-fix_patch_service_syntax May 30, 2024 05:30
@pengx17 pengx17 force-pushed the xp/05-27-fix_patch_service_syntax branch from 40697f5 to ca1e2f3 Compare May 30, 2024 09:39
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch from 604ff28 to 8ca961c Compare May 30, 2024 09:39
@pengx17 pengx17 marked this pull request as ready for review May 30, 2024 11:45
@pengx17 pengx17 force-pushed the xp/05-27-fix_patch_service_syntax branch from ca1e2f3 to da3cbc6 Compare May 30, 2024 11:46
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch 2 times, most recently from f5c2cee to 9ab60dc Compare May 30, 2024 14:32
@pengx17 pengx17 changed the base branch from xp/05-27-fix_patch_service_syntax to canary May 30, 2024 14:33
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch from 9ab60dc to 3c53b4f Compare May 31, 2024 02:03
@pengx17 pengx17 changed the base branch from canary to xp/05-31-chore_bump_blocksuite May 31, 2024 02:03
@pengx17 pengx17 mentioned this pull request May 31, 2024
@pengx17 pengx17 force-pushed the xp/05-31-chore_bump_blocksuite branch from 9989550 to 88aa368 Compare May 31, 2024 02:59
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch from 3c53b4f to 8d286e7 Compare May 31, 2024 02:59
@pengx17 pengx17 requested review from CatsJuice and EYHN May 31, 2024 03:02
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch from 8d286e7 to edd4d4b Compare May 31, 2024 05:36
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch from edd4d4b to a52eaa6 Compare May 31, 2024 05:40
@pengx17 pengx17 force-pushed the xp/05-31-chore_bump_blocksuite branch from 88aa368 to fe38a37 Compare May 31, 2024 05:42
@pengx17 pengx17 changed the base branch from xp/05-31-chore_bump_blocksuite to canary May 31, 2024 05:53
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch 2 times, most recently from a0dc00f to ca9c0f6 Compare May 31, 2024 06:46
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch from ca9c0f6 to ca6de7b Compare May 31, 2024 07:12
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch 3 times, most recently from 39a102a to 1431ed9 Compare May 31, 2024 07:43
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch from 1431ed9 to 44aacc2 Compare May 31, 2024 07:55
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch from 452946c to b933436 Compare May 31, 2024 08:21
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch 2 times, most recently from 0197640 to 0c742eb Compare May 31, 2024 09:41
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch from 0c742eb to 41158fc Compare May 31, 2024 09:51
@pengx17 pengx17 force-pushed the xp/05-27-feat_center_peek_view branch from 41158fc to 95b46fd Compare May 31, 2024 10:05
Copy link

graphite-app bot commented May 31, 2024

Merge activity

@EYHN EYHN force-pushed the xp/05-27-feat_center_peek_view branch from 95b46fd to ea0059f Compare May 31, 2024 10:29
@graphite-app graphite-app bot merged commit ea0059f into canary May 31, 2024
33 checks passed
@graphite-app graphite-app bot deleted the xp/05-27-feat_center_peek_view branch May 31, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:dev mod:i18n Related to i18n mod:infra Environment related issues and discussions
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants