-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: center peek view #7073
feat: center peek view #7073
Conversation
pengx17
commented
May 26, 2024
•
edited
Loading
edited
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ea0059f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #7073 +/- ##
===========================================
- Coverage 67.31% 32.04% -35.27%
===========================================
Files 612 595 -17
Lines 29863 11933 -17930
Branches 2684 2057 -627
===========================================
- Hits 20102 3824 -16278
+ Misses 9486 7878 -1608
+ Partials 275 231 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
36fb018
to
13b51c7
Compare
35ec701
to
604ff28
Compare
40697f5
to
ca1e2f3
Compare
604ff28
to
8ca961c
Compare
ca1e2f3
to
da3cbc6
Compare
f5c2cee
to
9ab60dc
Compare
9ab60dc
to
3c53b4f
Compare
9989550
to
88aa368
Compare
3c53b4f
to
8d286e7
Compare
8d286e7
to
edd4d4b
Compare
edd4d4b
to
a52eaa6
Compare
88aa368
to
fe38a37
Compare
a0dc00f
to
ca9c0f6
Compare
ca9c0f6
to
ca6de7b
Compare
packages/frontend/core/src/modules/peek-view/view/doc-peek-controls.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/core/src/modules/peek-view/view/doc-peek-controls.tsx
Outdated
Show resolved
Hide resolved
39a102a
to
1431ed9
Compare
packages/frontend/core/src/modules/peek-view/view/modal-container.tsx
Outdated
Show resolved
Hide resolved
1431ed9
to
44aacc2
Compare
packages/frontend/core/src/modules/peek-view/view/peek-view-manager.tsx
Outdated
Show resolved
Hide resolved
452946c
to
b933436
Compare
0197640
to
0c742eb
Compare
0c742eb
to
41158fc
Compare
41158fc
to
95b46fd
Compare
Merge activity
|
<div class='graphite__hidden'> <div>🎥 Video uploaded on Graphite:</div> <a href="https://app.graphite.dev/media/video/T2klNLEk0wxLh4NRDzhk/7380c06e-880e-424a-9204-8cfb5e924978.mp4"> <img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/T2klNLEk0wxLh4NRDzhk/7380c06e-880e-424a-9204-8cfb5e924978.mp4"> </a> </div> <video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/T2klNLEk0wxLh4NRDzhk/7380c06e-880e-424a-9204-8cfb5e924978.mp4">Kapture 2024-05-30 at 19.42.46.mp4</video>
95b46fd
to
ea0059f
Compare