Skip to content

fix(editor): add index checking to selected elements array #21573

fix(editor): add index checking to selected elements array

fix(editor): add index checking to selected elements array #21573

Triggered via pull request December 31, 2024 05:53
Status Cancelled
Total duration 7m 3s
Artifacts 8

build-test.yml

on: pull_request
Optimize CI
5s
Optimize CI
Matrix: build-native
Build Server native
51s
Build Server native
Build @affine/electron renderer
2m 4s
Build @affine/electron renderer
test-build-mobile-app  /  output-env
3s
test-build-mobile-app / output-env
Matrix: Analyze
Matrix: Legacy Blocksuite E2E Test
Matrix: E2E Mobile Test
Matrix: E2E Test
Matrix: Unit Test
Matrix: Server Copilot E2E Test
Matrix: server-e2e-test
Server Test
5m 21s
Server Test
Server Copilot Api Test
24s
Server Copilot Api Test
Matrix: desktop-test
test-build-mobile-app  /  build-android-web
2m 15s
test-build-mobile-app / build-android-web
test-build-mobile-app  /  build-ios-web
2m 7s
test-build-mobile-app / build-ios-web
test-build-mobile-app  /  android
2m 52s
test-build-mobile-app / android
test-build-mobile-app  /  ios
4m 5s
test-build-mobile-app / ios
3, 2, 1 Launch
0s
3, 2, 1 Launch
Fit to window
Zoom out
Zoom in

Annotations

41 errors, 48 warnings, and 19 notices
selection/native.spec.ts:266:1 › cursor move to up and down with children block: blocksuite/tests-legacy/selection/native.spec.ts#L295
1) selection/native.spec.ts:266:1 › cursor move to up and down with children block ─────────────── Error: expect(received).toBeGreaterThanOrEqual(expected) Expected: >= 12 Received: -1 293 | const textTwo = await getInlineSelectionText(page); 294 | expect(textTwo).toBe('arrow down test 1'); > 295 | expect(indexTwo).toBeGreaterThanOrEqual(12); | ^ 296 | expect(indexTwo).toBeLessThanOrEqual(17); 297 | await page.keyboard.press('ArrowDown'); 298 | const textThree = await getInlineSelectionText(page); at /home/runner/work/AFFiNE/AFFiNE/blocksuite/tests-legacy/selection/native.spec.ts:295:20
clipboard/list.spec.ts:215:1 › paste nested lists to a nested list: blocksuite/tests-legacy/utils/asserts.ts#L210
1) clipboard/list.spec.ts:215:1 › paste nested lists to a nested list ──────────────────────────── Error: expect(received).toEqual(expected) // deep equality - Expected - 2 + Received + 2 Array [ "aaa", - "111", + "bbb111", "222", "111", - "222bbb", + "222", "ccc", ] at utils/asserts.ts:210 208 | }); 209 | }, currentEditorIndex); > 210 | expect(actualTexts).toEqual(texts); | ^ 211 | } 212 | 213 | export async function assertEdgelessCanvasText(page: Page, text: string) { at assertRichTexts (/home/runner/work/AFFiNE/AFFiNE/blocksuite/tests-legacy/utils/asserts.ts:210:23) at /home/runner/work/AFFiNE/AFFiNE/blocksuite/tests-legacy/clipboard/list.spec.ts:257:3
edgeless/note/resize.spec.ts:138:1 › resize note then auto size and custom size: blocksuite/tests-legacy/utils/asserts.ts#L889
1) edgeless/note/resize.spec.ts:138:1 › resize note then auto size and custom size ─────────────── Error: expect(received).toBeCloseTo(expected, precision) Expected: 192 Received: 92 Expected precision: 0 Expected difference: < 0.5 Received difference: 100 at utils/asserts.ts:889 887 | expect(a.y).toBeCloseTo(b.y, 0); 888 | expect(a.w).toBeCloseTo(b.w, 0); > 889 | expect(a.h).toBeCloseTo(b.h, 0); | ^ 890 | } 891 | 892 | export function assertDOMRectEqual(a: DOMRect, b: DOMRect) { at assertRectEqual (/home/runner/work/AFFiNE/AFFiNE/blocksuite/tests-legacy/utils/asserts.ts:889:15) at assertNoteRectEqual (/home/runner/work/AFFiNE/AFFiNE/blocksuite/tests-legacy/utils/asserts.ts:882:3) at /home/runner/work/AFFiNE/AFFiNE/blocksuite/tests-legacy/edgeless/note/resize.spec.ts:188:3
Lint
Process completed with exit code 1.
edgeless/shortcut.spec.ts:119:1 › should not switch shapes in editing: blocksuite/tests-legacy/utils/actions/edgeless.ts#L368
1) edgeless/shortcut.spec.ts:119:1 › should not switch shapes in editing ───────────────────────── TimeoutError: locator.click: Timeout 5000ms exceeded. Call log: - waiting for locator('edgeless-slide-menu edgeless-tool-icon-button').filter({ hasText: 'Square' }) - locator resolved to <edgeless-tool-icon-button role="button">…</edgeless-tool-icon-button> - attempting click action 2 × waiting for element to be visible, enabled and stable - element is not stable - retrying click action - waiting 20ms - waiting for element to be visible, enabled and stable - element is not stable - retrying click action - waiting 100ms - waiting for element to be visible, enabled and stable - element was detached from the DOM, retrying at utils/actions/edgeless.ts:368 366 | .locator('edgeless-slide-menu edgeless-tool-icon-button') 367 | .filter({ hasText: shape }); > 368 | await squareShapeButton.click(); | ^ 369 | break; 370 | } 371 | } at setEdgelessTool (/home/runner/work/AFFiNE/AFFiNE/blocksuite/tests-legacy/utils/actions/edgeless.ts:368:31) at /home/runner/work/AFFiNE/AFFiNE/blocksuite/tests-legacy/edgeless/shortcut.spec.ts:137:3
links.spec.ts:249:5 › allow switching to embed view when linking to the other document with mode: tests/affine-local/e2e/links.spec.ts#L286
1) links.spec.ts:249:5 › allow switching to embed view when linking to the other document with mode TimeoutError: locator.click: Timeout 5000ms exceeded. Call log: - waiting for locator('affine-embed-linked-doc-block') - locator resolved to <affine-embed-linked-doc-block contenteditable="false" data-block-id="cSJ0_pqOg00qSxvfrWFHn">…</affine-embed-linked-doc-block> - attempting click action 2 × waiting for element to be visible, enabled and stable - element is visible, enabled and stable - scrolling into view if needed - done scrolling - <iframe src="about:blank" id="webpack-dev-server-client-overlay"></iframe> intercepts pointer events - retrying click action - waiting 20ms 2 × waiting for element to be visible, enabled and stable - element is visible, enabled and stable - scrolling into view if needed - done scrolling - <iframe src="about:blank" id="webpack-dev-server-client-overlay"></iframe> intercepts pointer events - retrying click action - waiting 100ms 9 × waiting for element to be visible, enabled and stable - element is visible, enabled and stable - scrolling into view if needed - done scrolling - <iframe src="about:blank" id="webpack-dev-server-client-overlay"></iframe> intercepts pointer events - retrying click action - waiting 500ms 284 | 285 | await expect(cardLink).toBeVisible(); > 286 | await cardLink.click(); | ^ 287 | 288 | // refocus 289 | await cardLink.click(); at /home/runner/work/AFFiNE/AFFiNE/tests/affine-local/e2e/links.spec.ts:286:18
attachment-preview.spec.ts:145:5 › should preview PDF in embed view: tests/affine-local/e2e/attachment-preview.spec.ts#L212
1) attachment-preview.spec.ts:145:5 › should preview PDF in embed view ─────────────────────────── TimeoutError: locator.click: Timeout 5000ms exceeded. Call log: - waiting for locator('.linked-doc-popover').getByText('PDF preview') 210 | 211 | const doc0 = page.locator('.linked-doc-popover').getByText('PDF preview'); > 212 | await doc0.click(); | ^ 213 | 214 | await page.keyboard.press('@'); 215 | at /home/runner/work/AFFiNE/AFFiNE/tests/affine-local/e2e/attachment-preview.spec.ts:212:16
blocksuite/outline.spec.ts:73:5 › outline viewer should be useable in doc peek preview: tests/affine-local/e2e/blocksuite/outline.spec.ts#L117
2) blocksuite/outline.spec.ts:73:5 › outline viewer should be useable in doc peek preview ──────── Error: Timed out 5000ms waiting for expect(locator).toHaveCount(expected) Locator: getByTestId('peek-view-modal').locator('affine-outline-viewer .outline-viewer-indicator') Expected: 3 Received: 2 Call log: - expect.toHaveCount with timeout 5000ms - waiting for getByTestId('peek-view-modal').locator('affine-outline-viewer .outline-viewer-indicator') 9 × locator resolved to 2 elements - unexpected value "2" 115 | 116 | const indicators = getIndicators(peekView); > 117 | await expect(indicators).toHaveCount(3); | ^ 118 | await expect(indicators.nth(0)).toBeVisible(); 119 | await expect(indicators.nth(1)).toBeVisible(); 120 | await expect(indicators.nth(2)).toBeVisible(); at /home/runner/work/AFFiNE/AFFiNE/tests/affine-local/e2e/blocksuite/outline.spec.ts:117:28
Desktop Test (windows-latest, windows, x64, x86_64-pc-windows-msvc, true)
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Unit Test (4)
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Unit Test (4)
The operation was canceled.
Server Test
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Server Test
The operation was canceled.
Server E2E Test 1/3
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Server E2E Test 1/3
The operation was canceled.
Server E2E Test 3/3
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Server E2E Test 3/3
The operation was canceled.
Analyze (javascript)
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Analyze (javascript)
The operation was canceled.
Server Desktop E2E Test
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Server Desktop E2E Test
The operation was canceled.
Analyze (typescript)
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Analyze (typescript)
The operation was canceled.
Unit Test (2)
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Unit Test (2)
The operation was canceled.
Unit Test (5)
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Unit Test (5)
The operation was canceled.
Unit Test (1)
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Unit Test (1)
The operation was canceled.
Server E2E Test 2/3
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Server E2E Test 2/3
The operation was canceled.
E2E Test (2)
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
E2E Test (2)
The operation was canceled.
Desktop Test (ubuntu-latest, linux, x64, x86_64-unknown-linux-gnu, true)
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
test-build-mobile-app / ios
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
test-build-mobile-app / ios
The operation was canceled.
Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
Canceling since a higher priority waiting request for 'Build & Test-refs/pull/9453/merge' exists
Desktop Test (macos-latest, macos, arm64, aarch64-apple-darwin, true)
The operation was canceled.
3, 2, 1 Launch
Process completed with exit code 1.
Optimize CI
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Check yarn binary
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test-build-mobile-app / output-env
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Build AFFiNE native (x86_64-unknown-linux-gnu)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Build Server native
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Server Copilot Api Test
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Server Copilot E2E Test (1, 3)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Server Copilot E2E Test (3, 3)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Server Copilot E2E Test (2, 3)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Build @affine/electron renderer
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Run native tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test-build-mobile-app / build-ios-web
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test-build-mobile-app / build-android-web
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
E2E Mobile Test (5)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Slow Test: tests/affine-mobile/[Mobile Chrome] › explorer-tag.spec.ts#L1
tests/affine-mobile/[Mobile Chrome] › explorer-tag.spec.ts took 46.4s
Legacy Blocksuite E2E Test (10)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
E2E Mobile Test (2)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Slow Test: tests/affine-mobile/[Mobile Safari] › explorer-folder.spec.ts#L1
tests/affine-mobile/[Mobile Safari] › explorer-folder.spec.ts took 51.1s
Legacy Blocksuite E2E Test (1)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Legacy Blocksuite E2E Test (9)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Legacy Blocksuite E2E Test (8)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
E2E Mobile Test (4)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Slow Test: tests/affine-mobile/[Mobile Chrome] › detail.spec.ts#L1
tests/affine-mobile/[Mobile Chrome] › detail.spec.ts took 46.7s
Slow Test: tests/affine-mobile/[Mobile Chrome] › explorer-favorite.spec.ts#L1
tests/affine-mobile/[Mobile Chrome] › explorer-favorite.spec.ts took 44.0s
E2E Mobile Test (3)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Slow Test: tests/affine-mobile/[Mobile Safari] › home.spec.ts#L1
tests/affine-mobile/[Mobile Safari] › home.spec.ts took 45.0s
E2E Mobile Test (1)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Slow Test: tests/affine-mobile/[Mobile Safari] › back-button-visibility.spec.ts#L1
tests/affine-mobile/[Mobile Safari] › back-button-visibility.spec.ts took 46.8s
Legacy Blocksuite E2E Test (2)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Legacy Blocksuite E2E Test (5)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Legacy Blocksuite E2E Test (7)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Legacy Blocksuite E2E Test (6)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
E2E Test (4)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Slow Test: tests/affine-local/local-first-favorites-items.spec.ts#L1
tests/affine-local/local-first-favorites-items.spec.ts took 39.5s
Legacy Blocksuite E2E Test (3)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
E2E Test (5)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
test-build-mobile-app / android
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Legacy Blocksuite E2E Test (4)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
E2E Test (3)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
E2E Test (1)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Unit Test (3)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Analyze (javascript)
1 issue was detected with this workflow: CodeQL language 'javascript' is referenced by more than one entry in the 'language' matrix parameter for job 'analyze'. This may result in duplicate alerts. Please edit the 'language' matrix parameter to keep only one of the following: 'javascript', 'typescript'.
Analyze (javascript)
Unable to validate code scanning workflow: DuplicateLanguageInMatrix
Analyze (typescript)
1 issue was detected with this workflow: CodeQL language 'javascript' is referenced by more than one entry in the 'language' matrix parameter for job 'analyze'. This may result in duplicate alerts. Please edit the 'language' matrix parameter to keep only one of the following: 'javascript', 'typescript'.
Analyze (typescript)
Unable to validate code scanning workflow: DuplicateLanguageInMatrix
test-build-mobile-app / ios
swiftformat 0.55.3 is already installed and up-to-date. To reinstall 0.55.3, run: brew reinstall swiftformat
3, 2, 1 Launch
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
🎭 Playwright Run Summary
7 passed (1.3m)
🎭 Playwright Run Summary
1 flaky selection/native.spec.ts:266:1 › cursor move to up and down with children block ──────────────── 3 skipped 94 passed (1.3m)
🎭 Playwright Run Summary
7 passed (1.6m)
🎭 Playwright Run Summary
1 flaky clipboard/list.spec.ts:215:1 › paste nested lists to a nested list ───────────────────────────── 3 skipped 95 passed (1.3m)
🎭 Playwright Run Summary
98 passed (1.5m)
🎭 Playwright Run Summary
3 skipped 95 passed (1.5m)
🎭 Playwright Run Summary
7 passed (1.3m)
🎭 Playwright Run Summary
7 passed (1.5m)
🎭 Playwright Run Summary
8 passed (1.8m)
🎭 Playwright Run Summary
4 skipped 95 passed (1.5m)
🎭 Playwright Run Summary
1 flaky edgeless/note/resize.spec.ts:138:1 › resize note then auto size and custom size ──────────────── 12 skipped 86 passed (2.2m)
🎭 Playwright Run Summary
1 skipped 97 passed (1.8m)
🎭 Playwright Run Summary
1 flaky edgeless/shortcut.spec.ts:119:1 › should not switch shapes in editing ────────────────────────── 4 skipped 93 passed (2.4m)
🎭 Playwright Run Summary
1 skipped 35 passed (3.4m)
🎭 Playwright Run Summary
6 skipped 93 passed (2.5m)
🎭 Playwright Run Summary
1 skipped 35 passed (3.5m)
🎭 Playwright Run Summary
1 skipped 98 passed (2.8m)
🎭 Playwright Run Summary
1 flaky links.spec.ts:249:5 › allow switching to embed view when linking to the other document with mode 2 skipped 33 passed (4.0m)
🎭 Playwright Run Summary
2 flaky attachment-preview.spec.ts:145:5 › should preview PDF in embed view ──────────────────────────── blocksuite/outline.spec.ts:73:5 › outline viewer should be useable in doc peek preview ───────── 1 skipped 34 passed (4.0m)

Artifacts

Produced during runtime
Name Size
affine.darwin-arm64.node
1.92 MB
affine.darwin-x64.node
2.04 MB
affine.linux-x64-gnu.node
2.08 MB
affine.win32-x64-msvc.node
2.43 MB
android
60.6 MB
ios
60.7 MB
server-native.node
4.32 MB
web
62.7 MB