Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): add index checking to selected elements array #9453

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

@L-Sun L-Sun requested a review from a team as a code owner December 31, 2024 05:53
@graphite-app graphite-app bot requested a review from forehalo December 31, 2024 05:53
Copy link

graphite-app bot commented Dec 31, 2024

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.64%. Comparing base (597b631) to head (b51de2a).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
.../root-block/widgets/element-toolbar/lock-button.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9453      +/-   ##
==========================================
- Coverage   51.83%   51.64%   -0.19%     
==========================================
  Files        2154     2154              
  Lines       97036    97039       +3     
  Branches    16208    16173      -35     
==========================================
- Hits        50297    50120     -177     
- Misses      45410    45588     +178     
- Partials     1329     1331       +2     
Flag Coverage Δ
server-test 78.07% <ø> (-0.65%) ⬇️
unittest 31.10% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Saul-Mirone commented Dec 31, 2024

Merge activity

  • Dec 31, 3:04 AM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 31, 3:04 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 31, 3:18 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot merged commit b51de2a into canary Dec 31, 2024
61 checks passed
@graphite-app graphite-app bot deleted the L-Sun-patch-1 branch December 31, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants