-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lazy loading of the JET integration #379
Conversation
@timholy I'd like to push this PR through quickly and I'm inclined to go ahead and merge it. However I'll hold off on putting out a new version just yet. If you have any feedback, please drop a comment. Otherwise, I'll look to release a new version when it feels appropriate. |
JET sometimes ends up being incompatible with the latest version of Julia, and it can also prevent SnoopCompile.jl from loading. To get around this, this commit makes the JET integration lazy-loaded, so that it does not prevent SnoopCompile.jl from loading.
Co-authored-by: Mark Kittisopikul <[email protected]>
Could you fix the tests? |
I didn't dig into the failure on the stable version. We should investigate it, but let's do that in a separate PR. |
Thanks for doing this! FYI, given infinite time I'd be slimming down the number of Julia versions supported and the overall functionality of this package to probably just |
#382 (comment) pointed out that perhaps we should still have a |
JET sometimes ends up being incompatible with the latest version of Julia, and it can also prevent SnoopCompile.jl from loading. To get around this, this commit makes the JET integration lazy-loaded, so that it does not prevent SnoopCompile.jl from loading.