Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy loading of the JET integration #379

Merged
merged 2 commits into from
Apr 10, 2024
Merged

lazy loading of the JET integration #379

merged 2 commits into from
Apr 10, 2024

Conversation

aviatesk
Copy link
Collaborator

JET sometimes ends up being incompatible with the latest version of Julia, and it can also prevent SnoopCompile.jl from loading. To get around this, this commit makes the JET integration lazy-loaded, so that it does not prevent SnoopCompile.jl from loading.

@aviatesk
Copy link
Collaborator Author

@timholy I'd like to push this PR through quickly and I'm inclined to go ahead and merge it. However I'll hold off on putting out a new version just yet. If you have any feedback, please drop a comment. Otherwise, I'll look to release a new version when it feels appropriate.

aviatesk and others added 2 commits April 10, 2024 23:27
JET sometimes ends up being incompatible with the latest version of
Julia, and it can also prevent SnoopCompile.jl from loading.
To get around this, this commit makes the JET integration lazy-loaded,
so that it does not prevent SnoopCompile.jl from loading.
@mkitti
Copy link
Contributor

mkitti commented Apr 10, 2024

Could you fix the tests?

@aviatesk
Copy link
Collaborator Author

I didn't dig into the failure on the stable version. We should investigate it, but let's do that in a separate PR.

@aviatesk aviatesk merged commit 37ff57b into master Apr 10, 2024
15 of 21 checks passed
@aviatesk aviatesk deleted the avi/lazy-jet branch April 10, 2024 14:43
@timholy
Copy link
Owner

timholy commented Apr 16, 2024

Thanks for doing this! FYI, given infinite time I'd be slimming down the number of Julia versions supported and the overall functionality of this package to probably just @snoopr, @snoopi_deep, and @snoopl. In other words, I'd support any efforts that aim in that direction, given suitable semver caretaking which you know all about.

@timholy timholy mentioned this pull request Apr 16, 2024
6 tasks
@timholy
Copy link
Owner

timholy commented Apr 18, 2024

#382 (comment) pointed out that perhaps we should still have a [compat] entry for JET?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants