-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JET versions before 0.8.28 are not compatible with Julia 1.11 #104585
Comments
CC: @aviatesk |
The primary issue is I ran into is when adding
|
I haven't had the chance to work on updating JET, so it hasn't been updated for v1.11 or later. |
Yes, I understand. The latest version of the package does at least precompile on Julia 1.11, so that other dependencies such as SnoopCompile.jl can load. The problem here is that earlier versions before the aforementioned patch do not precompile on Julia 1.11. However, because of the compatibility declarations of older versions of JET, they end up getting installed. In particular, when adding SnoopCompile, JET.jl 0.8.22 gets installed rather than JET.jl 0.8.29 which works. The older version is selected since the resolver prefers a newer version of LoweredCodeUtils.jl, version, 2.4, which it thinks is compatible with JET.jl 0.8.22. The proposed registry edits fix the compatibility so that all current JET.jl are only compatible with LoweredCodeUtils.jl up to 2.3. It also changes the compat for earlier versions of JET.jl to be only compatible to Julia 1.10. Are the above registry changes fine with you? |
Adding an upper bound to LCU for older JET versions doesn't seem like it would address the root of the issue, right? It looks like the real suggestion is to make JET compatible with Julia versions up to 1.10 (so making it uninstallable for v1.11 and onwards from the first place). But that's led to complications in JET's development, something I've deliberately stayed away from, so I'd really rather not go down that route. I'd propose this alternative timholy/SnoopCompile.jl#379, which makes SnoopCompile loadable on v1.11 and so on without JET installed successfully. |
JET.jl 0.8.29 loads fine on Julia 1.11 and with these edits will not have an upper bound for Julia. JET.jl 0.8.27 and earlier do not precompile on Julia 1.11. |
Note that I made the following pull request a couple months ago: |
Ah, I see. So the PR edits Julia upper bound for the earlier version of JET only. That sounds fine. And thanks for your PR on SnoopCompile! I just missed it. |
aviatesk/JET.jl#610
( aviatesk/JET.jl@cb07600 ) fixed an issue for JET 0.8.28+ so that it is compatible with Julia 1.11. This means that JET versions 0.8.27 and earlier are not compatible with Julia 1.11.
The text was updated successfully, but these errors were encountered: