Integrate JET via Requires.jl #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 83.99% // Head: 83.96% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 83.99% 83.96% -0.03%
==========================================
Files 17 18 +1
Lines 2162 2158 -4
==========================================
- Hits 1816 1812 -4
Misses 346 346
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Both SnoopCompile and JET are difficult to keep compatible with nightly and across older versions of Julia, so requiring that both are working (or even, just precompiling) simultaneously is twice the risk. If we put the JET integration under `@require`, then we can load SnoopCompile without JET.
timholy
force-pushed
the
teh/split_jet
branch
from
7e95315 to
fe3f96b
Compare
This was referenced Dec 13, 2022
|
This is made obsolete by #379 |
|
Yeah, this is superseded by #379. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both SnoopCompile and JET are difficult to keep compatible with nightly and across older versions of Julia, so requiring that both are working (or even, just precompiling) simultaneously is twice the risk. If we put the JET integration under
@require, then we can load SnoopCompile without JET.The sad part is that this should probably be viewed as a breaking change (now users have to manually load JET) and thus we need to go to 3.0.0.