*: fix typo #8982
*: fix typo #8982
Conversation
Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot
bot
added
release-note-none
| @@ -162,7 +162,7 @@ type Config struct { | |||
|
|
|||
| Keyspace KeyspaceConfig `toml:"keyspace" json:"keyspace"` | |||
|
|
|||
| MicroService MicroServiceConfig `toml:"micro-service" json:"micro-service"` | |||
| Microservice MicroserviceConfig `toml:"micro-service" json:"micro-service"` | |||
There was a problem hiding this comment.
Please pay attention that the name has been changed.
| GetMicroserviceMembers(context.Context, string) ([]MicroserviceMember, error) | ||
| GetMicroservicePrimary(context.Context, string) (string, error) |
There was a problem hiding this comment.
AFAIK, we don't use these API for now, so renaming them is ok.
| @@ -80,8 +80,8 @@ const ( | |||
| Version = "/pd/api/v1/version" | |||
| operators = "/pd/api/v1/operators" | |||
| safepoint = "/pd/api/v1/gc/safepoint" | |||
| // Micro Service | |||
| microServicePrefix = "/pd/api/v2/ms" | |||
| // Microservice | |||
There was a problem hiding this comment.
I'm going to keep it because it's not for exposed variables previously.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8982 +/- ##
==========================================
+ Coverage 74.91% 76.27% +1.35%
==========================================
Files 416 465 +49
Lines 42103 70550 +28447
==========================================
+ Hits 31543 53814 +22271
- Misses 7810 13379 +5569
- Partials 2750 3357 +607
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@niubell PTAL |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: niubell, nolouch, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #4820
What is changed and how does it work?
Check List
Tests
Release note