Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(tikv/pd): pd update required context on master #1139

Conversation

purelind
Copy link
Contributor

@purelind purelind commented Jan 8, 2025

update required context on pd master branch.

Related PR tikv/pd#8982.

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo January 8, 2025 08:31
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2025
@purelind
Copy link
Contributor Author

purelind commented Jan 8, 2025

/hold

wait for PR tikv/pd#8982 approve and review finished

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2025
@purelind
Copy link
Contributor Author

purelind commented Jan 8, 2025

/cc @rleungx

Copy link

ti-chi-bot bot commented Jan 8, 2025

@purelind: GitHub didn't allow me to request PR reviews from the following users: rleungx.

Note that only ti-community-infra members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @rleungx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 8, 2025
Copy link

ti-chi-bot bot commented Jan 8, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-08 08:36:13.295945894 +0000 UTC m=+342716.584777598: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Jan 8, 2025
Copy link

ti-chi-bot bot commented Jan 8, 2025

@rleungx: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rleungx, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@purelind
Copy link
Contributor Author

purelind commented Jan 8, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2025
@ti-chi-bot ti-chi-bot bot merged commit 06f1981 into ti-community-infra:main Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants