Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commander: Failsafe: set clear condition for action Land like for RTL #759

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

mehmetkillioglu
Copy link

This PR fetches the upstream changes introduced in this PR. (#23569)

In summary:

  • When there is a failsafe condition such as RC loss with Land as failsafe action, the land operation is cleared once the RC signal is regained. This is not the same with the RTL, where it doesnt get cleared out. When the land failsafe action is cleared, it goes back to user intention nav state, which is not desirable.
  • This PR prevent clearing the Land failsafe if the cause has been solved. Once it switches to Land failsafe, it will finalize that action unless mode changed manually or disarmed.

This change should be removed during the rebasing to a newer version of PX4-firmware.

@jnippula
Copy link

jnippula commented Sep 5, 2024

Could you add that statement also into the commit message? That would help the rebase work a lot.
"This change should be removed during the rebasing to a newer version of PX4-firmware."

… (OnModeChangeOrDisarm)

This change should be removed during the rebasing to a newer version of PX4-firmware.
@mehmetkillioglu mehmetkillioglu force-pushed the commander-dont-clear-land-failsafe branch from 2dedf58 to 27ef4fb Compare September 9, 2024 06:48
@mehmetkillioglu mehmetkillioglu merged commit 237cbe0 into main Sep 9, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants