Skip to content

Commit

Permalink
src/lib/drivers/magnetometer/PX4Magnetometer.cpp: Workaround for sens…
Browse files Browse the repository at this point in the history
…ors not initializing with all the magnetometers

There is some issue with "sensors" module; it only takes into account the magnetometers which have published data
before the module start.

Workaround this issue by publishing some initial "0" data right at the time of constructing the magnetometer driver.
If the probing of the sensor fails, the orb gets anyhow unadvertised, so there is no extra sensor data lying
around in the case the magnetometer is not present.

This also forces the magnetometer numbering to follow the startup order; without advertising the data
the orb numbering depends on magnetometer initialization sequence - a magnetometer started later in the
init scripts may publish it's first data before some other mag, which was started earlier. This is especially
problematic when using the same scripts on different HW platforms which run on different speeds.

Signed-off-by: Jukka Laitinen <[email protected]>
  • Loading branch information
jlaitine committed Nov 19, 2024
1 parent cd06105 commit 55f17c6
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/lib/drivers/magnetometer/PX4Magnetometer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,16 @@ PX4Magnetometer::PX4Magnetometer(uint32_t device_id, enum Rotation rotation) :
_device_id{device_id},
_rotation{rotation}
{
// Publish initial 0 data just for the sensors module to find
// this device, in case "sensors" module start up before initialization
// of the magnetometer is not fully complete

// TODO: This is a workaround. The "sensors" module should find the mags
// which start publishing data later

sensor_mag_s report = {};
report.device_id = _device_id;
_sensor_pub.publish(report);
}

PX4Magnetometer::~PX4Magnetometer()
Expand Down

0 comments on commit 55f17c6

Please sign in to comment.