catalyst-audit: L-04 ERC20 transfer return value lacks validation#1108

Merged

rishabh0x00 merged 117 commits intocatalyst-audit/L-03-deploying-royalty-splitter-instance-may-emit-incorrect-recipient-in-eventfrom catalyst-audit/L-04-erc20-transfer-return-value-lacks-validation

Sep 11, 2023

+531-434

Commits on Sep 7, 2023

refactor : ERC20 transfer call using SafeERC20
Rishabh Sharma
committed
fix : added royaltyBPS into royaltyConfigs
Rishabh Sharma
committed
feat : added test case
Rishabh Sharma
committed
refactor: removed unused code
Rishabh Sharma
committed
fix: fixed and removed test cases
Rishabh Sharma
committed
fix : updated docstrings
Rishabh Sharma
committed
fix: updated doc string
Rishabh Sharma
committed
fix: fixed docstring
Rishabh Sharma
committed
fix : added onlyInitializing modifier
Rishabh Sharma
committed
feat : added events after sensitive changes
Rishabh Sharma
committed
feat : added events in interface
Rishabh Sharma
committed
feat : added test cases
Rishabh Sharma
committed
refactor : update function structure for event handling
Rishabh Sharma
committed
refactor : _setBaseURI with super call
Rishabh Sharma
committed
fix: removed merge markers
Rishabh Sharma
committed
fix: fixed test cases
Rishabh Sharma
committed
feat : added events after sensitive changes
Rishabh Sharma
committed
feat : added test cases
Rishabh Sharma
committed
feat : added a gap variable
Rishabh Sharma
committed
fix : fixed merge conflict
Rishabh Sharma
committed
Fix the gap length

wojciech-turek
authored and
Rishabh Sharma
committed
feat : added events after sensitive changes
Rishabh Sharma
committed
fix : updated missing docstring
Rishabh Sharma
committed
fix: updated comment format
Rishabh Sharma
committed
fix: fixed merge conflict
Rishabh Sharma
committed
feat : added failing test cases for burn and transfer
Rishabh Sharma
committed
refactor : variables names
Rishabh Sharma
committed
fix : updated splitter abi
Rishabh Sharma
committed
fix : updated test cases
Rishabh Sharma
committed
fix: fixed test case
Rishabh Sharma
committed
fix : updated splitter abi
Rishabh Sharma
committed
fix : updated constant format
Rishabh Sharma
committed
refactor : marked RoyaltyDistributor as abstract
Rishabh Sharma
committed
fix : updated a test case
Rishabh Sharma
committed
feat : added events after sensitive changes
Rishabh Sharma
committed
fix : added '_disableInitializers()' in constructor
Rishabh Sharma
committed
fix: fixed merge conflict
Rishabh Sharma
committed
feat : added events after sensitive changes
Rishabh Sharma
committed
fix : updated missing docstring
Rishabh Sharma
committed
fix : added '_disableInitializers()' in constructor
Rishabh Sharma
committed
fix : updated incomplete docstrings
Rishabh Sharma
committed
fix: removed duplicate constructor
Rishabh Sharma
committed
feat : added events after sensitive changes
Rishabh Sharma
committed
fix : updated missing docstring
Rishabh Sharma
committed
fix : added named return values
Rishabh Sharma
committed
refactor : enhance function with named return values
Rishabh Sharma
committed
fix: updated contracts and interfaces
Rishabh Sharma
committed
fix: format fixed
Rishabh Sharma
committed
return the values directly

wojciech-turek
authored and
Rishabh Sharma
committed
feat : added events after sensitive changes
Rishabh Sharma
committed
fix : updated missing docstring
Rishabh Sharma
committed
refactor : enhance function with named return values
Rishabh Sharma
committed
return the values directly

wojciech-turek
authored and
Rishabh Sharma
committed
refactor : variables names
Rishabh Sharma
committed
fix : added '_disableInitializers()' in constructor
Rishabh Sharma
committed
fix : updated incomplete docstrings
Rishabh Sharma
committed
fix : added indexed params in events
Rishabh Sharma
committed
fix: removed duplicate constructor
Rishabh Sharma
committed
feat : added events after sensitive changes
Rishabh Sharma
committed
fix : updated missing docstring
Rishabh Sharma
committed
refactor : enhance function with named return values
Rishabh Sharma
committed
return the values directly

wojciech-turek
authored and
Rishabh Sharma
committed
fix : added missing parent initializer calls in contract
Rishabh Sharma
committed
feat : added events after sensitive changes
Rishabh Sharma
committed
fix : updated missing docstring
Rishabh Sharma
committed
refactor : enhance function with named return values
Rishabh Sharma
committed
return the values directly

wojciech-turek
authored and
Rishabh Sharma
committed
fix : updated functions visibility to external
Rishabh Sharma
committed
fix: function visibility
Rishabh Sharma
committed

Commits on Sep 8, 2023

fix: updated function visibility
Rishabh Sharma
committed
feat : added events after sensitive changes
Rishabh Sharma
committed
fix : updated missing docstring
Rishabh Sharma
committed
refactor : enhance function with named return values
Rishabh Sharma
committed
return the values directly

wojciech-turek
authored and
Rishabh Sharma
committed
fix : fixed redundant code
Rishabh Sharma
committed
fix: removed redundent code
Rishabh Sharma
committed
refactor : enhance function with named return values
Rishabh Sharma
committed
return the values directly

wojciech-turek
authored and
Rishabh Sharma
committed
refactor : enhance function with named return values
Rishabh Sharma
committed
return the values directly

wojciech-turek
authored and
Rishabh Sharma
committed
fix : fixed typographical errors
Rishabh Sharma
committed
Fix typographical errors

wojciech-turek
authored and
Rishabh Sharma
committed
refactor : enhance function with named return values
Rishabh Sharma
committed
return the values directly

wojciech-turek
authored and
Rishabh Sharma
committed
refactor : enhance function with named return values
Rishabh Sharma
committed
return the values directly

wojciech-turek
authored and
Rishabh Sharma
committed
refactor : enhance function with named return values
Rishabh Sharma
committed
return the values directly

wojciech-turek
authored and
Rishabh Sharma
committed
refactor : used named return royalBps variable
Rishabh Sharma
committed
fix: added missing function
Rishabh Sharma
committed
fix: format:fix
Rishabh Sharma
committed
refactor : enhance function with named return values
Rishabh Sharma
committed
return the values directly

wojciech-turek
authored and
Rishabh Sharma
committed
fix: added missing function
Rishabh Sharma
committed
fix : removed unused variables
Rishabh Sharma
committed
fix: fixed format
Rishabh Sharma
committed
refactor: removed royaltyBps value allocation
Rishabh Sharma
committed
Update the gap size
wojciech-turek
committed

Commits on Sep 11, 2023