catalyst-audit: L-04 ERC20 transfer return value lacks validation #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh0x00
requested review from
mvanmeerbeck and
atkinsonholly
and removed request for
a team
wojciech-turek
approved these changes
Aug 28, 2023
atkinsonholly
approved these changes
Aug 29, 2023
rishabh0x00
force-pushed
the
catalyst-audit/L-04-erc20-transfer-return-value-lacks-validation
branch
from
dbc26a5 to
672dad7
Compare
rishabh0x00
force-pushed
the
catalyst-audit/L-03-deploying-royalty-splitter-instance-may-emit-incorrect-recipient-in-event
branch
from
605efd9 to
8d397a7
Compare
rishabh0x00
force-pushed
the
catalyst-audit/L-04-erc20-transfer-return-value-lacks-validation
branch
from
672dad7 to
13fd8e1
Compare
…ed-variables catalyst-audit: N-18 unused variables
…graphical-errors Catalyst audit: N-14 typographical errors
…ndant-code catalyst-audit: N-12 redundant code
…ic-functions-that-should-have-external-visibility Catalyst audit: N-11 public functions that should have external visibility
…ing-calls-to-inherited-contract-initializers Catalyst audit: N-10 Missing Calls to Inherited Contract Initializers
…-of-indexed-event-parameters Catalyst audit: N-09 Lack of Indexed Event Parameters
…nsistent-use-of-named-return-values Catalyst audit: N-08 Inconsistent Use of Named Return Values
…mplete-docstrings Catalyst audit: N-06 Incomplete Docstrings
…bleInitializers-function-not-called-in-multiple-initializable-contract-constructors Catalyst audit: N-05 _disableInitializers() Not Called in Multiple Initializable Contract Constructors
…ract-should-be-abstract Catalyst audit: N-04 Contract Should Be Abstract
…tant-not-using-upper-case-format Catalyst audit: N-03 Constant Not Using UPPER_CASE Format
…ng-style-deviates-from-solidity-style-guide Catalyst audit: N-02 Coding Style Deviates From Solidity Style Guide
…catalyst-contract-allows-the-burning-and-transfer-of-non-existent-tokens Catalyst audit: L-11 The Catalyst Contract Allows the Burning and Transfer of Non-Existent Tokens
…ing-docstrings Catalyst audit: L 10 missing docstrings
…-of-gap-variables Catalyst audit: L 09 lack of gap variables
…-of-event-emission-after-sensitive-action Catalyst audit: L 08 lack of event emission after sensitive action
…ializer-functions-can-be-called-after-initialization Catalyst audit: L-07 initializer functions can be called after initialization
…rrect-documentation Catalyst audit: L-06 incorrect documentation
…mplete-data-in-struct-with-royalty-information Catalyst audit: L-05 incomplete data in struct with royalty information
rishabh0x00
merged commit 3c2a449
into
catalyst-audit/L-03-deploying-royalty-splitter-instance-may-emit-incorrect-recipient-in-event
mvanmeerbeck
deleted the
catalyst-audit/L-04-erc20-transfer-return-value-lacks-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catalyst and dependencies audit report fixes
Link to Jira Issue or relevant doc
Dev
Any explanation for the devs that will review your implementation/code.
Qa
Any guidance or important information for the team that will be testing your solution.
Checklist and Markdown