[TheiaProk suite] Patch fix: change type of kraken2_report to be string in taxon_table task #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #298
🛠️ Changes Being Made
This PR addresses an issue found during validation where the type for the krakrn2 report output was not being passed correctly to the export taxon table task.
This has been patched.
Impacted Workflows/Tasks
TheiaProk suite of workflows:
🧠 Context and Rationale
export taxon tables task was expecting a
File
input for thekraken_report
but due to it being an optional output, it is being handled as a String by the Theiaprok workflow (SE and PE).📋 Workflow/Task Steps
Inputs
N/A
Outputs
N/A
Impacted Outputs
🧪 Testing
Locally
N/A
Terra
Set of 20 bacterial genomes with taxon tables task enabled, as well as kraken2 optional module (one expected failure due to SRA lite file format issue): https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Mendes_Sandbox/job_history/805a3537-a339-4b05-99bd-8ec4c1b18a32
Scenarios for Reviewer to Test
🔬 Quality checks
Pull Request (PR) checklist: