Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding bed file input #190

Merged
merged 1 commit into from
Sep 20, 2023
Merged

adding bed file input #190

merged 1 commit into from
Sep 20, 2023

Conversation

jrotieno
Copy link
Contributor

@jrotieno jrotieno commented Sep 15, 2023

Closes #189

🛠️ Changes Being Made

Added an optional snippy_core_bed file input to the Snippy_Tree workflow, and thereby exposing this optional input to the Snippy_Streamline workflow

🧠 Context and Rationale

Whereas a bed file optional input can be used to mask an alignment in Snippy_Tree, this input is not exposed as an option in Snippy_Streamline. This limits ability to use Snippy_Streamline for TB phylogenetics that needs masking of certain repeat regions.

📋 Workflow/Task Steps

Inputs

the added optional input snippy_core_bed

Outputs

Remain the same

🧪 Testing

Locally

Input exposed locally

Terra

Input exposed on Terra

🔬 Quality checks

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The workflow/task has been tested locally and on Terra
  • The CI/CD has been adjusted and tests are passing
  • Everything follows the style guide

Copy link
Contributor

@emmadoughty emmadoughty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

Tested on Terra: https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Doughty_Sandbox/job_history/72c20877-46e5-48a1-8b28-7a8dc40d06e8

Confirmed that output is exposed in Snippy_Streamline workflow and bed file is being used to mask the alignment.

Great work getting this sorted!

@kevinlibuit kevinlibuit merged commit 82e4b48 into main Sep 20, 2023
@jrotieno jrotieno deleted the jro_snippy_streamline_addBed branch September 21, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants