-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update arrowhead label positioning and use label dimensions #1207
Update arrowhead label positioning and use label dimensions #1207
Conversation
d6d4c67
to
a9b18e8
Compare
46ab88a
to
974daad
Compare
974daad
to
913c170
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice. just some nits. can you include a sketch test as well to make sure it works in sketch mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are there so many cases updated? Specially, cases without arrowhead labels
updated d2target srcLabel and dstLabel to Text type @@ -1227,10 +1221,8 @@
"id": "(h.m.s -> a.f.g)[0]",
"src": "h.m.s",
"srcArrow": "none",
- "srcLabel": "",
"dst": "a.f.g",
"dstArrow": "triangle",
- "dstLabel": "",
"opacity": 1,
"strokeDash": 0,
"strokeWidth": 2, |
Summary
Improves arrowhead positioning and handling of large arrowhead labels.
Details
1
or*
, but the scenario of having longer arrowhead labels wasn't accounted forbefore
after
long arrowhead before/after
new test before
new test after