Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrowhead label and shape may clash #823

Closed
bo-ku-ra opened this issue Feb 15, 2023 · 4 comments · Fixed by #880
Closed

arrowhead label and shape may clash #823

bo-ku-ra opened this issue Feb 15, 2023 · 4 comments · Fixed by #880

Comments

@bo-ku-ra
Copy link
Contributor

ex.
https://play.d2lang.com/?l=&script=qlDQtVOo5KqsrqrlAgQAAP__&

'y' seems like an arrowhead.
i preffer v0.1.6 rendering.
@cyborg-ts cyborg-ts added this to D2 Feb 15, 2023
@bo-ku-ra bo-ku-ra changed the title isthis lavel "Much more legible"? is this label "Much more legible"? Feb 15, 2023
@bo-ku-ra
Copy link
Contributor Author

incompatible with arrowhead

ex.
https://play.d2lang.com/?l=&script=qlDQtVOotFKo5lJQQNdppZCWnw-WUVAA-8lKISUzMTc_LwUiBLJdDxL4VgolRaWpXAoKtVy1XFyVVgpJiUUK1VW1XIAAAAD__w%3D%3D&

@bo-ku-ra bo-ku-ra changed the title is this label "Much more legible"? incompatible with arrowhead Feb 15, 2023
This was referenced Feb 21, 2023
Closed
Merged
@alixander alixander changed the title incompatible with arrowhead arrowhead label and shape may clash Feb 23, 2023
@alixander
Copy link
Collaborator

the core issue with labels is fixed. i've changed this issue slightly to specify that the problem is the arrowhead label and shape may still overlap each other.

221047691-77407518-cc8e-449d-855c-4b3ab3bbbfc2

@github-project-automation github-project-automation bot moved this to Done in D2 Feb 23, 2023
@alixander alixander reopened this Feb 23, 2023
@bo-ku-ra
Copy link
Contributor Author

https://play.d2lang.com/?script=qlDQtVOo5KrUq-SqtFKohAKuKogwIAAA__8%3D&

i preffer v0.1.6 rendering.
image

@bo-ku-ra bo-ku-ra mentioned this issue Feb 28, 2023
Closed
@gavin-ts
Copy link
Contributor

gavin-ts commented May 2, 2023

arrowhead label overlapping with the arrowhead itself is fixed in #1207

@gavin-ts gavin-ts closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
D2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dagre: stop container edges at container label gavin-ts/d2
3 participants
@alixander @gavin-ts @bo-ku-ra