Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go.mod and github actions to sync with supported release versions of pipeline and kubernetes #1181

Closed
wants to merge 2 commits into from
Closed

Fix go.mod and github actions to sync with supported release versions of pipeline and kubernetes #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6766ac0
Bump the all group across 1 directory with 25 updates
dependabot[bot] Sep 2, 2024
ce574d7
Updates go.mod and github actions to sync with supported release vers…
PuneetPunamiya Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
13 changes: 7 additions & 6 deletions .github/workflows/kind-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ jobs:
fail-fast: false # Keep running if one leg fails.
matrix:
# Keep in sync with the list of supported releases: https://kubernetes.io/releases/
# TODO: add 1.31.x once it is added in https://github.com/sigstore/scaffolding/releases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I check which versions are supported?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github action uses this script to install kind cluster and if fetches from the version specified here https://github.com/tektoncd/chains/blob/main/.github/workflows/reusable-e2e.yaml#L30
And here I did not see 1.31.x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. It would be great to add a little comment here pointing to the script.

k8s-version:
- v1.27.x
- v1.28.x
- v1.29.x
- v1.30.x
Expand All @@ -31,11 +31,12 @@ jobs:
fail-fast: false # Keep running if one leg fails.
matrix:
pipelines-release:
PuneetPunamiya marked this conversation as resolved.
Show resolved Hide resolved
- v0.44.4 # LTS
- v0.47.3 # LTS
- v0.50.1 # LTS
- v0.51.0
# This should follow the list of versions from https://github.com/tektoncd/pipeline/blob/main/releases.md#release
- v0.50.5 # LTS
- v0.53.5 # LTS
- v0.56.3 # LTS
- v0.59.2 # LTS
lcarva marked this conversation as resolved.
Show resolved Hide resolved
uses: ./.github/workflows/reusable-e2e.yaml
with:
k8s-version: v1.27.x
k8s-version: v1.28.x
pipelines-release: ${{ matrix.pipelines-release }}
1 change: 1 addition & 0 deletions .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: latest
args: --new-from-rev=$(git merge-base origin/main HEAD)

# Optional: working directory, useful for monorepos
# working-directory: somedir
Expand Down
4 changes: 2 additions & 2 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ run:
issues-exit-code: 1
build-tags:
- e2e
# skip-dirs:
# - vendor
skip-dirs:
- vendor
timeout: 20m
modules-download-mode: vendor
314 changes: 157 additions & 157 deletions go.mod
View file
Open in desktop

Large diffs are not rendered by default.

779 changes: 387 additions & 392 deletions go.sum
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ header "Setting up environment"
# Test against nightly instead of latest.
install_tkn

export RELEASE_YAML="https://storage.googleapis.com/tekton-releases/pipeline/previous/v0.59.2/release.yaml"
export RELEASE_YAML="https://storage.googleapis.com/tekton-releases/pipeline/previous/v0.62.0/release.yaml"
install_pipeline_crd

install_chains
Expand Down
12 changes: 12 additions & 0 deletions vendor/cloud.google.com/go/.gitignore
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions vendor/cloud.google.com/go/.release-please-manifest-individual.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

148 changes: 148 additions & 0 deletions vendor/cloud.google.com/go/.release-please-manifest-submodules.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions vendor/cloud.google.com/go/.release-please-manifest.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading