Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go.mod and github actions to sync with supported release versions of pipeline and kubernetes #1181

Closed
wants to merge 2 commits into from
Closed

Fix go.mod and github actions to sync with supported release versions of pipeline and kubernetes #1181

wants to merge 2 commits into from

Conversation

PuneetPunamiya
Copy link
Member

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 21, 2024
lcarva
lcarva approved these changes Aug 21, 2024
View reviewed changes
.github/workflows/kind-e2e.yaml
@@ -17,8 +17,8 @@ jobs:
fail-fast: false # Keep running if one leg fails.
matrix:
# Keep in sync with the list of supported releases: https://kubernetes.io/releases/
# TODO: add 1.31.x once it is added in https://github.com/sigstore/scaffolding/releases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I check which versions are supported?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github action uses this script to install kind cluster and if fetches from the version specified here https://github.com/tektoncd/chains/blob/main/.github/workflows/reusable-e2e.yaml#L30
And here I did not see 1.31.x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. It would be great to add a little comment here pointing to the script.

.github/workflows/kind-e2e.yaml Show resolved Hide resolved
.github/workflows/kind-e2e.yaml Show resolved Hide resolved
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
@lcarva
Copy link
Contributor

lcarva commented Aug 21, 2024

Not sure what's up with all the linting failures. It might be checking the files under the vendor directory? Let's configure the linter to ignore those.

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 22, 2024
@PuneetPunamiya
Copy link
Member Author

/test pull-tekton-chains-unit-tests

@PuneetPunamiya PuneetPunamiya force-pushed the fix-go.mod branch 4 times, most recently from e8fb136 to af525c4 Compare September 6, 2024 12:07
dependabot bot and others added 2 commits September 10, 2024 18:46
@dependabot @PuneetPunamiya
Bump the all group across 1 directory with 25 updates
6766ac0 
Bumps the all group with 10 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [cloud.google.com/go/compute/metadata](https://github.com/googleapis/google-cloud-go) | `0.3.0` | `0.5.0` |
| [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) | `1.40.0` | `1.43.0` |
| [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) | `1.57.2` | `1.60.3` |
| [github.com/google/go-containerregistry](https://github.com/google/go-containerregistry) | `0.19.1` | `0.20.2` |
| [github.com/in-toto/attestation](https://github.com/in-toto/attestation) | `1.0.1` | `1.1.0` |
| [github.com/sigstore/cosign/v2](https://github.com/sigstore/cosign) | `2.2.4` | `2.4.0` |
| [github.com/tektoncd/pipeline](https://github.com/tektoncd/pipeline) | `0.58.0` | `0.63.0` |
| [gocloud.dev](https://github.com/google/go-cloud) | `0.37.0` | `0.39.0` |
| [gocloud.dev/docstore/mongodocstore](https://github.com/google/go-cloud) | `0.37.1-0.20240501181211-d8b9c9401f18` | `0.39.0` |
| [gocloud.dev/pubsub/kafkapubsub](https://github.com/google/go-cloud) | `0.37.0` | `0.39.0` |



Updates `cloud.google.com/go/compute/metadata` from 0.3.0 to 0.5.0
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md)
- [Commits](googleapis/google-cloud-go@v0.3.0...v0.5.0)

Updates `cloud.google.com/go/storage` from 1.40.0 to 1.43.0
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md)
- [Commits](googleapis/google-cloud-go@pubsub/v1.40.0...spanner/v1.43.0)

Updates `github.com/golangci/golangci-lint` from 1.57.2 to 1.60.3
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.57.2...v1.60.3)

Updates `github.com/google/go-containerregistry` from 0.19.1 to 0.20.2
- [Release notes](https://github.com/google/go-containerregistry/releases)
- [Changelog](https://github.com/google/go-containerregistry/blob/main/.goreleaser.yml)
- [Commits](google/go-containerregistry@v0.19.1...v0.20.2)

Updates `github.com/in-toto/attestation` from 1.0.1 to 1.1.0
- [Release notes](https://github.com/in-toto/attestation/releases)
- [Commits](in-toto/attestation@v1.0.1...v1.1.0)

Updates `github.com/sigstore/cosign/v2` from 2.2.4 to 2.4.0
- [Release notes](https://github.com/sigstore/cosign/releases)
- [Changelog](https://github.com/sigstore/cosign/blob/main/CHANGELOG.md)
- [Commits](sigstore/cosign@v2.2.4...v2.4.0)

Updates `github.com/sigstore/sigstore` from 1.8.3 to 1.8.8
- [Release notes](https://github.com/sigstore/sigstore/releases)
- [Commits](sigstore/sigstore@v1.8.3...v1.8.8)

Updates `github.com/sigstore/sigstore/pkg/signature/kms/aws` from 1.8.3 to 1.8.8
- [Release notes](https://github.com/sigstore/sigstore/releases)
- [Commits](sigstore/sigstore@v1.8.3...v1.8.8)

Updates `github.com/sigstore/sigstore/pkg/signature/kms/azure` from 1.8.3 to 1.8.8
- [Release notes](https://github.com/sigstore/sigstore/releases)
- [Commits](sigstore/sigstore@v1.8.3...v1.8.8)

Updates `github.com/sigstore/sigstore/pkg/signature/kms/gcp` from 1.8.3 to 1.8.8
- [Release notes](https://github.com/sigstore/sigstore/releases)
- [Commits](sigstore/sigstore@v1.8.3...v1.8.8)

Updates `github.com/sigstore/sigstore/pkg/signature/kms/hashivault` from 1.8.3 to 1.8.8
- [Release notes](https://github.com/sigstore/sigstore/releases)
- [Commits](sigstore/sigstore@v1.8.3...v1.8.8)

Updates `github.com/spiffe/go-spiffe/v2` from 2.2.0 to 2.3.0
- [Release notes](https://github.com/spiffe/go-spiffe/releases)
- [Changelog](https://github.com/spiffe/go-spiffe/blob/main/CHANGELOG.md)
- [Commits](spiffe/go-spiffe@v2.2.0...v2.3.0)

Updates `github.com/tektoncd/pipeline` from 0.58.0 to 0.63.0
- [Release notes](https://github.com/tektoncd/pipeline/releases)
- [Changelog](https://github.com/tektoncd/pipeline/blob/main/releases.md)
- [Commits](tektoncd/pipeline@v0.58.0...v0.63.0)

Updates `gocloud.dev` from 0.37.0 to 0.39.0
- [Release notes](https://github.com/google/go-cloud/releases)
- [Commits](google/go-cloud@v0.37.0...v0.39.0)

Updates `gocloud.dev/docstore/mongodocstore` from 0.37.1-0.20240501181211-d8b9c9401f18 to 0.39.0
- [Release notes](https://github.com/google/go-cloud/releases)
- [Commits](https://github.com/google/go-cloud/commits/v0.39.0)

Updates `gocloud.dev/pubsub/kafkapubsub` from 0.37.0 to 0.39.0
- [Release notes](https://github.com/google/go-cloud/releases)
- [Commits](google/go-cloud@v0.37.0...v0.39.0)

Updates `golang.org/x/crypto` from 0.22.0 to 0.26.0
- [Commits](golang/crypto@v0.22.0...v0.26.0)

Updates `golang.org/x/exp` from 0.0.0-20240103183307-be819d1f06fc to 0.0.0-20240719175910-8a7402abbf56
- [Commits](https://github.com/golang/exp/commits)

Updates `google.golang.org/grpc` from 1.63.2 to 1.65.0
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.63.2...v1.65.0)

Updates `google.golang.org/protobuf` from 1.33.0 to 1.34.2

Updates `k8s.io/api` from 0.28.3 to 0.29.6
- [Commits](kubernetes/api@v0.28.3...v0.29.6)

Updates `k8s.io/apimachinery` from 0.29.0 to 0.29.7
- [Commits](kubernetes/apimachinery@v0.29.0...v0.29.7)

Updates `k8s.io/client-go` from 0.28.3 to 0.29.6
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.28.3...v0.29.6)

Updates `k8s.io/code-generator` from 0.26.5 to 0.29.7
- [Commits](kubernetes/code-generator@v0.26.5...v0.29.7)

Updates `knative.dev/pkg` from 0.0.0-20231023150739-56bfe0dd9626 to 0.0.0-20240416145024-0f34a8815650
- [Commits](https://github.com/knative/pkg/commits)

---
updated-dependencies:
- dependency-name: cloud.google.com/go/compute/metadata
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: cloud.google.com/go/storage
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: github.com/google/go-containerregistry
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: github.com/in-toto/attestation
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: github.com/sigstore/cosign/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: github.com/sigstore/sigstore
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: github.com/sigstore/sigstore/pkg/signature/kms/aws
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: github.com/sigstore/sigstore/pkg/signature/kms/azure
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: github.com/sigstore/sigstore/pkg/signature/kms/gcp
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: github.com/sigstore/sigstore/pkg/signature/kms/hashivault
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: github.com/spiffe/go-spiffe/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: github.com/tektoncd/pipeline
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: gocloud.dev
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: gocloud.dev/docstore/mongodocstore
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: gocloud.dev/pubsub/kafkapubsub
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: golang.org/x/exp
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
- dependency-name: k8s.io/client-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: k8s.io/code-generator
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: knative.dev/pkg
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all
...

Signed-off-by: dependabot[bot] <[email protected]>
@PuneetPunamiya
Updates go.mod and github actions to sync with supported release vers…
ce574d7 
…ions of pipeline and kubernetes

Signed-off-by: PuneetPunamiya <[email protected]>
@PuneetPunamiya
Copy link
Member Author

Since the number of file changes exceeds, we might have to separately bump the dependencies as the golangci lint github action is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcarva lcarva lcarva approved these changes

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

@wlynch wlynch Awaiting requested review from wlynch

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PuneetPunamiya @tekton-robot @lcarva