Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new v2alpha4 version for TaskRuns #1111

Merged

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented May 3, 2024

Related with: #1065

This new version will now process the information from any associated StepAction from the executed TaskRun.

Also, the way chains read results from TaskRun to populate the subjects field is changing: now the user has to explicitly mark a result as a subject using an bject type-hinted tag (*ARTIFACT_OUTPUTS) + the new isBuildArtifact property in the value

NOTE: Updating the Tekton version used in e2e tests to enable StepActions is breaking the Rekor behavior. A tracking issue was opened in #1117. After we solve that issue we would be able to add back the integration test with StepActions. We evaluated to do the test using the GitHub actions but we don't have an easy way to target an specific e2e test to not run in all the matrix of Pipeline releases. Also looks like GitHub tests are only testing one case.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@tekton-robot
Copy link

Hi @renzodavid9. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 3, 2024
@tekton-robot tekton-robot requested review from lcarva and wlynch May 3, 2024 17:01
@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch 2 times, most recently from d4c6dd2 to aaab6d7 Compare May 6, 2024 13:46
@renzodavid9 renzodavid9 marked this pull request as ready for review May 6, 2024 14:19
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@tekton-robot tekton-robot requested a review from chitrangpatel May 6, 2024 14:19
@chitrangpatel
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2024
@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch from aaab6d7 to ad42c97 Compare May 6, 2024 14:28
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 74.2% 3.6
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 50.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 13.3%
pkg/chains/formats/slsa/extract/extract.go 62.3% 66.2% 3.9
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 84.3%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 31.2% -1.5

@renzodavid9
Copy link
Contributor Author

/retest

1 similar comment
@chitrangpatel
Copy link
Contributor

/retest

@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch from ad42c97 to 67726fe Compare May 7, 2024 21:32
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 74.2% 3.6
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 65.8% 3.5
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 91.7%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 88.9%
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.2% -7.5

@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch from 67726fe to c4f3e41 Compare May 8, 2024 16:49
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 74.2% 3.6
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 8.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 65.8% 3.5
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 91.7%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 88.9%
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.2% -7.5

@renzodavid9 renzodavid9 requested a review from chitrangpatel May 8, 2024 19:22
@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch from c4f3e41 to cc88a97 Compare May 9, 2024 21:27
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 74.2% 3.6
pkg/chains/formats/format.go Do not exist 11.4%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 65.8% 3.5
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 91.7%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 88.9%
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.2% -7.5

@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch from cc88a97 to 602ffcf Compare May 9, 2024 21:33
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 74.2% 3.6
pkg/chains/formats/format.go 20.0% 10.0% -10.0
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 65.8% 3.5
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 91.7%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 88.9%
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.2% -7.5

@chitrangpatel
Copy link
Contributor

/retest

@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 73.9% 3.3
pkg/chains/formats/format.go Do not exist 6.7%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 67.1% 4.7
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 80.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go 58.3% 41.7% -16.7
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 16.7%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 80.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 77.6% 73.2% -4.4
pkg/chains/formats/slsa/v1/taskrun/taskrun.go 61.9% 54.2% -7.7
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 83.8% 78.5% -5.3
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.6% -7.1

@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch from 35a0998 to a1633e3 Compare May 20, 2024 21:09
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 73.9% 3.3
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/format.go Do not exist 6.7%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 67.1% 4.7
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 80.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go 58.3% 41.7% -16.7
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 16.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 80.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 77.6% 73.2% -4.4
pkg/chains/formats/slsa/v1/taskrun/taskrun.go 61.9% 54.2% -7.7
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 83.8% 78.5% -5.3
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.6% -7.1

@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch 2 times, most recently from 2200ea4 to ce90cb6 Compare May 20, 2024 21:28
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 73.9% 3.3
pkg/chains/formats/format.go 20.0% 6.7% -13.3
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 67.1% 4.7
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 80.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go 58.3% 41.7% -16.7
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 16.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 80.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 77.6% 73.2% -4.4
pkg/chains/formats/slsa/v1/taskrun/taskrun.go 61.9% 54.2% -7.7
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 83.8% 78.5% -5.3
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.6% -7.1

@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch from ce90cb6 to 7f0127e Compare May 20, 2024 21:35
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 73.9% 3.3
pkg/chains/formats/format.go 20.0% 10.0% -10.0
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 6.7%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 67.1% 4.7
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 80.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go 58.3% 41.7% -16.7
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 16.7%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 80.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 77.6% 73.2% -4.4
pkg/chains/formats/slsa/v1/taskrun/taskrun.go 61.9% 54.2% -7.7
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 83.8% 78.5% -5.3
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.6% -7.1

@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch 2 times, most recently from e391065 to fe57763 Compare May 20, 2024 21:51
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 73.9% 3.3
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 6.7%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 67.1% 4.7
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 80.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go 58.3% 0.0% -58.3
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 16.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 80.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 77.6% 73.2% -4.4
pkg/chains/formats/slsa/v1/taskrun/taskrun.go 61.9% 54.2% -7.7
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 83.8% 78.5% -5.3
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.6% -7.1

@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch from fe57763 to 9339b2c Compare May 21, 2024 03:50
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 73.9% 3.3
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 6.7%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 67.4% 5.1
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 80.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go 58.3% 20.8% -37.5
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 16.7%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/material/v1beta1/material.go 92.2% 92.3% 0.1
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 80.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 77.6% 73.2% -4.4
pkg/chains/formats/slsa/v1/taskrun/taskrun.go 61.9% 54.2% -7.7
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 83.8% 78.5% -5.3
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.6% -7.1

@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch from 9339b2c to 46d1109 Compare May 21, 2024 03:56
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 73.9% 3.3
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 6.7%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 67.4% 5.1
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 80.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go 58.3% 41.7% -16.7
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 16.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/material/v1beta1/material.go 92.2% 92.3% 0.1
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 80.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 77.6% 73.2% -4.4
pkg/chains/formats/slsa/v1/taskrun/taskrun.go 61.9% 54.2% -7.7
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 83.8% 78.5% -5.3
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.6% -7.1

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
This new version will now process the information from any associated StepAction from the executed TaskRun.

Also, the way chains read results from TaskRun to populate the `subjects` field is changing: now the user has to explicitly mark a result as a subject using an bject type-hinted tag (*ARTIFACT_OUTPUTS) + the new `isBuildArtifact` property in the value
@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch from 46d1109 to 89cd6c6 Compare May 21, 2024 15:25
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 73.9% 3.3
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 6.7%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 67.4% 5.1
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 80.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go 58.3% 41.7% -16.7
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 16.7%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/material/v1beta1/material.go 92.2% 92.3% 0.1
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 80.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 77.6% 73.2% -4.4
pkg/chains/formats/slsa/v1/taskrun/taskrun.go 61.9% 54.2% -7.7
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 83.8% 78.5% -5.3
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.6% -7.1

@renzodavid9 renzodavid9 force-pushed the 1065-stepactions-taskrun-attestation branch from 89cd6c6 to 1611c11 Compare May 21, 2024 15:47
@tekton-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/artifacts/signable.go 70.6% 73.9% 3.3
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 0.0%
pkg/chains/formats/format.go Do not exist 10.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 20.0%
pkg/chains/formats/format.go Do not exist 6.7%
pkg/chains/formats/format.go Do not exist 100.0%
pkg/chains/formats/slsa/extract/extract.go 62.3% 67.4% 5.1
pkg/chains/formats/slsa/internal/build_definition/build_definition.go Do not exist 80.0%
pkg/chains/formats/slsa/internal/compare/slsacompare.go 58.3% 0.0% -58.3
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 8.3%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 41.7%
pkg/chains/formats/slsa/internal/compare/slsacompare.go Do not exist 16.7%
pkg/chains/formats/slsa/internal/material/material.go 92.3% 92.9% 0.6
pkg/chains/formats/slsa/internal/material/v1beta1/material.go 92.2% 92.3% 0.1
pkg/chains/formats/slsa/internal/metadata/metadata.go Do not exist 100.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 0.0%
pkg/chains/formats/slsa/internal/provenance/provenance.go Do not exist 76.9%
pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go 87.6% 87.9% 0.3
pkg/chains/formats/slsa/internal/results/results.go Do not exist 80.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 75.0%
pkg/chains/formats/slsa/v1/internal/protos/protos.go Do not exist 0.0%
pkg/chains/formats/slsa/v1/pipelinerun/pipelinerun.go 77.6% 73.2% -4.4
pkg/chains/formats/slsa/v1/taskrun/taskrun.go 61.9% 54.2% -7.7
pkg/chains/formats/slsa/v2alpha3/internal/pipelinerun/pipelinerun.go 83.8% 78.5% -5.3
pkg/chains/formats/slsa/v2alpha3/internal/taskrun/taskrun.go 86.5% 81.2% -5.2
pkg/chains/formats/slsa/v2alpha4/internal/taskrun/taskrun.go Do not exist 80.0%
pkg/chains/formats/slsa/v2alpha4/slsav2.go Do not exist 85.7%
pkg/chains/objects/objects.go 32.7% 25.6% -7.1

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chitrangpatel,lcarva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chitrangpatel
Copy link
Contributor

Thanks for the linter fixes!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@tekton-robot tekton-robot merged commit 8e9373e into tektoncd:main May 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants