more linter errors

pkg/artifacts/signable_test.go

@@ -46,7 +46,6 @@ const (
 var ignore = []cmp.Option{cmpopts.IgnoreUnexported(name.Registry{}, name.Repository{}, name.Digest{})}
 
 func TestOCIArtifact_ExtractObjects(t *testing.T) {
-
 	tests := []struct {
 		name string
 		obj  objects.TektonObject
@@ -808,6 +807,7 @@ func TestExtractBuildArtifactsFromResults(t *testing.T) {
 }
 
 func createDigest(t *testing.T, dgst string) name.Digest {
+	t.Helper()
 	result, err := name.NewDigest(dgst)
 	if err != nil {
 		t.Fatal(err)

pkg/chains/formats/slsa/extract/extract.go

@@ -77,7 +77,8 @@ func subjectsFromPipelineRun(ctx context.Context, obj objects.TektonObject, slsa
 
 	pSpec := pro.Status.PipelineSpec
 	if pSpec != nil {
-		pipelineTasks := append(pSpec.Tasks, pSpec.Finally...)
+		pipelineTasks := pSpec.Tasks
+		pipelineTasks = append(pipelineTasks, pSpec.Finally...)
 		for _, t := range pipelineTasks {
 			tr := pro.GetTaskRunFromTask(t.Name)
 			// Ignore Tasks that did not execute during the PipelineRun.

pkg/chains/formats/slsa/extract/extract_test.go

@@ -120,7 +120,6 @@ func TestSubjectDigestsAndRetrieveAllArtifactURIs(t *testing.T) {
 					t.Errorf("Wrong URIs extracted, diff=%s", diff)
 				}
 			}
-
 		})
 	}
 }
@@ -209,7 +208,7 @@ func TestPipelineRunObserveModeForSubjects(t *testing.T) {
 		{
 			name: "deep inspection enabled: pipelinerun and taskrun have duplicated results",
 			pro: createProWithTaskRunResults(
-				createProWithPipelineResults(map[string]string{artifactURL1: "sha256:" + artifactDigest1}).(*objects.PipelineRunObjectV1),
+				createProWithPipelineResults(map[string]string{artifactURL1: "sha256:" + artifactDigest1}),
 				[]artifact{
 					{uri: artifactURL1, digest: "sha256:" + artifactDigest1},
 				}),
@@ -229,7 +228,7 @@ func TestPipelineRunObserveModeForSubjects(t *testing.T) {
 		{
 			name: "deep inspection enabled: pipelinerun and taskrun have different results",
 			pro: createProWithTaskRunResults(
-				createProWithPipelineResults(map[string]string{artifactURL1: "sha256:" + artifactDigest1}).(*objects.PipelineRunObjectV1),
+				createProWithPipelineResults(map[string]string{artifactURL1: "sha256:" + artifactDigest1}),
 				[]artifact{
 					{uri: artifactURL2, digest: "sha256:" + artifactDigest2},
 				}),
@@ -441,7 +440,7 @@ func TestSubjectsFromBuildArtifact(t *testing.T) {
 	}
 }
 
-func createTaskRunObjectWithResults(results map[string]string) objects.TektonObject {
+func createTaskRunObjectWithResults(results map[string]string) *objects.TaskRunObjectV1 {
 	trResults := []v1.TaskRunResult{}
 	prefix := 0
 	for url, digest := range results {
@@ -463,7 +462,7 @@ func createTaskRunObjectWithResults(results map[string]string) objects.TektonObj
 	)
 }
 
-func createProWithPipelineResults(results map[string]string) objects.TektonObject {
+func createProWithPipelineResults(results map[string]string) *objects.PipelineRunObjectV1 {
 	prResults := []v1.PipelineRunResult{}
 	prefix := 0
 	for url, digest := range results {

pkg/chains/formats/slsa/extract/v1beta1/extract.go

@@ -55,6 +55,7 @@ func SubjectDigests(ctx context.Context, obj objects.TektonObject, slsaconfig *s
 	return subjects
 }
 
+// SubjectsFromPipelineRunV1Beta1 returns software artifacts produced from the PipelineRun object.
 func SubjectsFromPipelineRunV1Beta1(ctx context.Context, obj objects.TektonObject, slsaconfig *slsaconfig.SlsaConfig) []*intoto.ResourceDescriptor {
 	prSubjects := SubjectsFromTektonObjectV1Beta1(ctx, obj)
 
@@ -90,6 +91,7 @@ func SubjectsFromPipelineRunV1Beta1(ctx context.Context, obj objects.TektonObjec
 	return result
 }
 
+// SubjectsFromTektonObjectV1Beta1 returns software artifacts produced from the Tekton object.
 func SubjectsFromTektonObjectV1Beta1(ctx context.Context, obj objects.TektonObject) []*intoto.ResourceDescriptor {
 	logger := logging.FromContext(ctx)
 	var subjects []*intoto.ResourceDescriptor

pkg/chains/formats/slsa/extract/v1beta1/extract_test.go

@@ -209,7 +209,7 @@ func TestPipelineRunObserveModeForSubjects(t *testing.T) {
 		{
 			name: "deep inspection enabled: pipelinerun and taskrun have duplicated results",
 			pro: createProWithTaskRunResults(
-				createProWithPipelineResults(map[string]string{artifactURL1: "sha256:" + artifactDigest1}).(*objects.PipelineRunObjectV1Beta1),
+				createProWithPipelineResults(map[string]string{artifactURL1: "sha256:" + artifactDigest1}),
 				[]artifact{
 					{uri: artifactURL1, digest: "sha256:" + artifactDigest1},
 				}),
@@ -229,7 +229,7 @@ func TestPipelineRunObserveModeForSubjects(t *testing.T) {
 		{
 			name: "deep inspection enabled: pipelinerun and taskrun have different results",
 			pro: createProWithTaskRunResults(
-				createProWithPipelineResults(map[string]string{artifactURL1: "sha256:" + artifactDigest1}).(*objects.PipelineRunObjectV1Beta1),
+				createProWithPipelineResults(map[string]string{artifactURL1: "sha256:" + artifactDigest1}),
 				[]artifact{
 					{uri: artifactURL2, digest: "sha256:" + artifactDigest2},
 				}),
@@ -272,7 +272,7 @@ func TestPipelineRunObserveModeForSubjects(t *testing.T) {
 	}
 }
 
-func createTaskRunObjectV1Beta1WithResults(results map[string]string) objects.TektonObject {
+func createTaskRunObjectV1Beta1WithResults(results map[string]string) *objects.TaskRunObjectV1Beta1 {
 	trResults := []v1beta1.TaskRunResult{}
 	prefix := 0
 	for url, digest := range results {
@@ -294,7 +294,7 @@ func createTaskRunObjectV1Beta1WithResults(results map[string]string) objects.Te
 	)
 }
 
-func createProWithPipelineResults(results map[string]string) objects.TektonObject {
+func createProWithPipelineResults(results map[string]string) *objects.PipelineRunObjectV1Beta1 {
 	prResults := []v1beta1.PipelineRunResult{}
 	prefix := 0
 	for url, digest := range results {

pkg/chains/formats/slsa/internal/build_definition/build_definition_test.go

@@ -113,12 +113,13 @@ func TestUnsupportedBuildType(t *testing.T) {
 	if err == nil {
 		t.Error("getBuildDefinition(): expected error got nil")
 	}
-	if diff := cmp.Diff(slsa.BuildDefinition{}, got, protocmp.Transform()); diff != "" {
+	if diff := cmp.Diff(&slsa.BuildDefinition{}, &got, protocmp.Transform()); diff != "" {
 		t.Errorf("getBuildDefinition(): -want +got: %s", diff)
 	}
 }
 
 func getProtoStruct(t *testing.T, data map[string]any) *structpb.Struct {
+	t.Helper()
 	protoStruct, err := getStruct(data)
 	if err != nil {
 		t.Fatalf("error getting proto struct from data: %v", err)

pkg/chains/formats/slsa/internal/material/v1beta1/material.go

@@ -74,7 +74,8 @@ func PipelineMaterials(ctx context.Context, pro *objects.PipelineRunObjectV1Beta
 	}
 	pSpec := pro.Status.PipelineSpec
 	if pSpec != nil {
-		pipelineTasks := append(pSpec.Tasks, pSpec.Finally...)
+		pipelineTasks := pSpec.Tasks
+		pipelineTasks = append(pipelineTasks, pSpec.Finally...)
 		for _, t := range pipelineTasks {
 			tr := pro.GetTaskRunFromTask(t.Name)
 			// Ignore Tasks that did not execute during the PipelineRun.
@@ -269,7 +270,8 @@ func FromPipelineParamsAndResults(ctx context.Context, pro *objects.PipelineRunO
 		// search type hinting param/results from each individual taskruns
 		if slsaconfig.DeepInspectionEnabled {
 			logger := logging.FromContext(ctx)
-			pipelineTasks := append(pSpec.Tasks, pSpec.Finally...)
+			pipelineTasks := pSpec.Tasks
+			pipelineTasks = append(pipelineTasks, pSpec.Finally...)
 			for _, t := range pipelineTasks {
 				tr := pro.GetTaskRunFromTask(t.Name)
 				// Ignore Tasks that did not execute during the PipelineRun.

pkg/chains/formats/slsa/internal/metadata/metadata_test.go

@@ -27,7 +27,7 @@ import (
 )
 
 func TestMetadata(t *testing.T) {
-	tr := &v1.TaskRun{ //nolint:staticcheck
+	tr := &v1.TaskRun{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      "my-taskrun",
 			Namespace: "my-namespace",
@@ -58,7 +58,7 @@ func TestMetadata(t *testing.T) {
 
 func TestMetadataInTimeZone(t *testing.T) {
 	tz := time.FixedZone("Test Time", int((12 * time.Hour).Seconds()))
-	tr := &v1.TaskRun{ //nolint:staticcheck
+	tr := &v1.TaskRun{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      "my-taskrun",
 			Namespace: "my-namespace",

pkg/chains/formats/slsa/internal/provenance/provenance.go

@@ -51,12 +51,12 @@ func GetSLSA1Statement(obj objects.TektonObject, sub []*intoto.ResourceDescripto
 
 func getProtoStruct(predicate *slsa.Provenance) (*structpb.Struct, error) {
 	protoStruct := &structpb.Struct{}
-	predicateJson, err := protojson.Marshal(predicate)
+	predicateJSON, err := protojson.Marshal(predicate)
 	if err != nil {
 		return nil, err
 	}
 
-	err = protojson.Unmarshal(predicateJson, protoStruct)
+	err = protojson.Unmarshal(predicateJSON, protoStruct)
 	if err != nil {
 		return nil, err
 	}

pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies.go

@@ -50,7 +50,7 @@ const (
 
 // used to toggle the fields in  see AddTektonTaskDescriptor
 // and AddSLSATaskDescriptor
-type addTaskDescriptorContent func(*objects.TaskRunObjectV1) (*intoto.ResourceDescriptor, error) //nolint:staticcheck
+type addTaskDescriptorContent func(*objects.TaskRunObjectV1) (*intoto.ResourceDescriptor, error)
 
 // ResolveOptions represents the configuration to be use to resolve dependencies.
 type ResolveOptions struct {
@@ -111,7 +111,7 @@ func RemoveDuplicateResolvedDependencies(resolvedDependencies []*intoto.Resource
 
 // AddTektonTaskDescriptor returns the more verbose resolved dependency content. this adds the name, uri, digest
 // and content if possible.
-func AddTektonTaskDescriptor(tr *objects.TaskRunObjectV1) (*intoto.ResourceDescriptor, error) { //nolint:staticcheck
+func AddTektonTaskDescriptor(tr *objects.TaskRunObjectV1) (*intoto.ResourceDescriptor, error) {
 	rd := intoto.ResourceDescriptor{}
 	storedTr, err := json.Marshal(tr)
 	if err != nil {
@@ -130,7 +130,7 @@ func AddTektonTaskDescriptor(tr *objects.TaskRunObjectV1) (*intoto.ResourceDescr
 
 // AddSLSATaskDescriptor resolves dependency content for the more generic slsa verifiers. just logs
 // the name, uri and digest.
-func AddSLSATaskDescriptor(tr *objects.TaskRunObjectV1) (*intoto.ResourceDescriptor, error) { //nolint:staticcheck
+func AddSLSATaskDescriptor(tr *objects.TaskRunObjectV1) (*intoto.ResourceDescriptor, error) {
 	if tr.Status.Provenance != nil && tr.Status.Provenance.RefSource != nil {
 		return &intoto.ResourceDescriptor{
 			Name:   PipelineTaskConfigName,

pkg/chains/formats/slsa/internal/resolved_dependencies/resolved_dependencies_test.go

@@ -303,7 +303,7 @@ func tektonTaskRuns() map[string][]byte {
 func TestTaskRun(t *testing.T) {
 	tests := []struct {
 		name        string
-		obj         objects.TektonObject //nolint:staticcheck
+		obj         objects.TektonObject
 		resolveOpts ResolveOptions
 		want        []*intoto.ResourceDescriptor
 	}{
@@ -375,7 +375,7 @@ func TestTaskRun(t *testing.T) {
 		},
 		{
 			name: "resolvedDependencies from remote task",
-			obj: objects.NewTaskRunObjectV1(&v1.TaskRun{ //nolint:staticcheck
+			obj: objects.NewTaskRunObjectV1(&v1.TaskRun{
 				Status: v1.TaskRunStatus{
 					TaskRunStatusFields: v1.TaskRunStatusFields{
 						Provenance: &v1.Provenance{
@@ -401,7 +401,7 @@ func TestTaskRun(t *testing.T) {
 		},
 		{
 			name: "git resolvedDependencies from taskrun params",
-			obj: objects.NewTaskRunObjectV1(&v1.TaskRun{ //nolint:staticcheck
+			obj: objects.NewTaskRunObjectV1(&v1.TaskRun{
 				Spec: v1.TaskRunSpec{
 					Params: []v1.Param{{
 						Name:  "CHAINS-GIT_COMMIT",
@@ -424,7 +424,7 @@ func TestTaskRun(t *testing.T) {
 		},
 		{
 			name: "resolvedDependencies from step images",
-			obj: objects.NewTaskRunObjectV1(&v1.TaskRun{ //nolint:staticcheck
+			obj: objects.NewTaskRunObjectV1(&v1.TaskRun{
 				Status: v1.TaskRunStatus{
 					TaskRunStatusFields: v1.TaskRunStatusFields{
 						Steps: []v1.StepState{{
@@ -457,7 +457,7 @@ func TestTaskRun(t *testing.T) {
 		},
 		{
 			name: "resolvedDependencies from step and sidecar images",
-			obj: objects.NewTaskRunObjectV1(&v1.TaskRun{ //nolint:staticcheck
+			obj: objects.NewTaskRunObjectV1(&v1.TaskRun{
 				Status: v1.TaskRunStatus{
 					TaskRunStatusFields: v1.TaskRunStatusFields{
 						Steps: []v1.StepState{{
@@ -507,7 +507,7 @@ func TestTaskRun(t *testing.T) {
 			resolveOpts: ResolveOptions{
 				WithStepActionsResults: true,
 			},
-			obj: objects.NewTaskRunObjectV1(&v1.TaskRun{ //nolint:staticcheck
+			obj: objects.NewTaskRunObjectV1(&v1.TaskRun{
 				Status: v1.TaskRunStatus{
 					TaskRunStatusFields: v1.TaskRunStatusFields{
 						Steps: []v1.StepState{{

pkg/chains/formats/slsa/internal/results/results_test.go

@@ -190,6 +190,7 @@ func TestGetResultsWithoutBuildArtifacts(t *testing.T) {
 }
 
 func toJSONString(t *testing.T, val v1.ParamValue) []byte {
+	t.Helper()
 	res, err := json.Marshal(val)
 	if err != nil {
 		t.Fatalf("error converting to json string: %v", err)

pkg/chains/formats/slsa/v1/internal/protos/protos.go

@@ -10,13 +10,13 @@ import (
 
 // GetPredicateStruct returns a protobuf struct from the given SLSAv0.2 predicate.
 func GetPredicateStruct(predicate *slsa.ProvenancePredicate) (*structpb.Struct, error) {
-	predicateJson, err := json.Marshal(predicate)
+	predicateJSON, err := json.Marshal(predicate)
 	if err != nil {
 		return nil, err
 	}
 
 	predicateStruct := &structpb.Struct{}
-	err = protojson.Unmarshal(predicateJson, predicateStruct)
+	err = protojson.Unmarshal(predicateJSON, predicateStruct)
 	if err != nil {
 		return nil, err
 	}