Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#271) dms-application detekt 적용 #282

Merged
merged 6 commits into from
Feb 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 4 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,7 @@ jobs:
arguments: |
build
--build-cache
--no-daemon
--no-daemon

- name: Run Detekt
run: ./gradlew :dms-application:detekt
15 changes: 15 additions & 0 deletions build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
plugins {
kotlin("jvm") version PluginVersions.JVM_VERSION
id("io.gitlab.arturbosch.detekt").version(PluginVersions.DETEKT_VERSION)
}

subprojects {
Expand All @@ -13,6 +14,18 @@ subprojects {
version = PluginVersions.KAPT_VERSION
}

apply {
plugin("io.gitlab.arturbosch.detekt")
version = PluginVersions.DETEKT_VERSION
}

detekt {
toolVersion = PluginVersions.DETEKT_VERSION
buildUponDefaultConfig = true
autoCorrect = true
config = files("config/detekt/detekt.yml")
}

dependencies {

// kotlin
Expand All @@ -26,6 +39,8 @@ subprojects {
// test
implementation(Dependencies.SPRING_TEST)
implementation(Dependencies.MOCKK)

detektPlugins(Dependencies.DETEKT)
}
}

Expand Down
3 changes: 3 additions & 0 deletions buildSrc/src/main/kotlin/Dependencies.kt
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,7 @@ object Dependencies {
// excel
const val APACHE_POI = "org.apache.poi:poi:${DependencyVersions.APACHE_POI_VERSION}"
const val APACHE_POI_OOXML = "org.apache.poi:poi-ooxml:${DependencyVersions.APACHE_POI_VERSION}"

// detekt
const val DETEKT = "io.gitlab.arturbosch.detekt:detekt-formatting:${PluginVersions.DETEKT_VERSION}"
}
1 change: 1 addition & 0 deletions buildSrc/src/main/kotlin/PluginVersions.kt
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ object PluginVersions {
const val KAPT_VERSION = "1.7.10"
const val ALLOPEN_VERSION = "1.6.21"
const val MOCKK_VERSION = "1.13.2"
const val DETEKT_VERSION = "1.21.0"
}
Loading