Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge: (#271) dms-application detekt 적용 #282

Merged
merged 6 commits into from
Feb 26, 2023
Merged

Conversation

softpeanut
Copy link
Member

@softpeanut softpeanut commented Feb 26, 2023

작업 내용 설명

  • dms-application 모듈에 detekt를 적용하였습니다. (다른 모듈은 autoCorrect만 적용된 상태)

주요 변경 사항

  • 너무 많지만 열심히 봐주시면 감사하겠습니다..
  • 모듈에 따라 detekt가 적용될 부분이 다르다고 판단되어서 설정 파일을 분리하였으니 참고해주세요!

결과물

앞으로 작업한 후 해당 task 실행시켜주시면 됩니다!

image

detekt 플러그인 설치하시고 해당 설정해주시면 됩니다!

image

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@softpeanut softpeanut added the refactor 코드 리팩토링 할 경우 label Feb 26, 2023
@softpeanut softpeanut self-assigned this Feb 26, 2023
@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #282 (3680850) into main (3b9ad3a) will increase coverage by 0.10%.
The diff coverage is 75.72%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #282      +/-   ##
============================================
+ Coverage     40.76%   40.87%   +0.10%     
+ Complexity      666      655      -11     
============================================
  Files           399      400       +1     
  Lines          4810     4817       +7     
  Branches        225      204      -21     
============================================
+ Hits           1961     1969       +8     
+ Misses         2828     2827       -1     
  Partials         21       21              
Impacted Files Coverage Δ
.../aliens/dms/common/extension/LocalDateExtension.kt 75.00% <0.00%> (-15.00%) ⬇️
...ens/dms/domain/auth/dto/CertifyEmailCodeRequest.kt 44.44% <ø> (ø)
.../aliens/dms/domain/auth/dto/CertifyEmailRequest.kt 100.00% <ø> (ø)
...team/aliens/dms/domain/auth/dto/ReissueResponse.kt 100.00% <ø> (ø)
...aliens/dms/domain/auth/dto/SendEmailCodeRequest.kt 42.85% <ø> (ø)
...n/team/aliens/dms/domain/auth/dto/SignInRequest.kt 100.00% <ø> (ø)
.../team/aliens/dms/domain/auth/dto/SignInResponse.kt 100.00% <ø> (ø)
...n/auth/exception/AuthCodeLimitNotFoundException.kt 100.00% <ø> (ø)
...domain/auth/exception/AuthCodeNotFoundException.kt 100.00% <ø> (ø)
...n/auth/exception/EmailAlreadyCertifiedException.kt 100.00% <ø> (ø)
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b9ad3a...3680850. Read the comment docs.

Copy link
Member

@rlaisqls rlaisqls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 정말 많으셨습니다! :D 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@softpeanut softpeanut requested a review from rlaisqls February 26, 2023 10:41
Copy link
Member

@tedsoftj1123 tedsoftj1123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다👏👏

@softpeanut softpeanut merged commit c98d7ac into main Feb 26, 2023
@softpeanut softpeanut deleted the feature/271-detekt-lint branch February 26, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 코드 리팩토링 할 경우
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detekt lint 추가
3 participants