Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent Invalid Pointer when loading extensions on Windows, rename with_extension_path -> with_extensions_path #1421

Merged
merged 6 commits into from
Nov 19, 2024
Merged

fix: Prevent Invalid Pointer when loading extensions on Windows, rename with_extension_path -> with_extensions_path #1421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f52532
fix: rename with_extension_path -> with_extensions_path
SpikeHD Nov 19, 2024
8b08a66
fix: AddBrowserExtension handler
SpikeHD Nov 19, 2024
699fd3c
fix: change file
SpikeHD Nov 19, 2024
78443f3
fix: add rename to change file
SpikeHD Nov 19, 2024
ee342da
Revert "fix: rename with_extension_path -> with_extensions_path"
SpikeHD Nov 19, 2024
02e0222
fix: remove name change from change file
SpikeHD Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/extension_fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wry": "patch"
---

Fix extension loading on Windows.
3 changes: 2 additions & 1 deletion src/webview2/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,8 +1252,9 @@ impl InnerWebView {
for entry in fs::read_dir(extension_path)? {
let path = entry?.path();
let path_hs = HSTRING::from(path.as_path());
let handler = ProfileAddBrowserExtensionCompletedHandler::create(Box::new(|_, _| Ok(())));

profile.AddBrowserExtension(&path_hs, None)?;
profile.AddBrowserExtension(&path_hs, &handler)?;
}

Ok(())
Expand Down