fix: Prevent Invalid Pointer when loading extensions on Windows, rename with_extension_path -> with_extensions_path
#1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
requested changes
Nov 19, 2024
src/lib.rs
Outdated
| @@ -1302,7 +1302,7 @@ pub trait WebViewBuilderExtWindows { | |||
| /// Set the path from which to load extensions from. Extensions stored in this path should be unpacked. | |||
| /// | |||
| /// Does nothing if browser extensions are disabled. See [`with_browser_extensions_enabled`](Self::with_browser_extensions_enabled) | |||
| fn with_extension_path(self, path: impl Into<PathBuf>) -> Self; | |||
| fn with_extensions_path(self, path: impl Into<PathBuf>) -> Self; | |||
There was a problem hiding this comment.
let's revert this naming change so I can release the fix as a patch version, we can rename in another PR afterwards.
This reverts commit 5f52532.
SpikeHD
force-pushed
the
patch/extension_loading
branch
from
ae6d674
to
ee342da
Compare
amrbashir
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes loading extensions on Windows by providing a handler function to
AddBrowserExtension, rather thanNone, which causes aInvalid Pointererror.Also renames the function
with_extension_path->with_extensions_path, as the name might be misleading/confusing.