fix bug in non constant params

sys-bio · Feb 22, 2024 · 96b2e7b · 96b2e7b
1 parent f647a74
commit 96b2e7b
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/ratesb_python/common/analyzer.py b/ratesb_python/common/analyzer.py
@@ -594,10 +594,14 @@ def _check_constant_parameters(self, **kwargs):
         reaction_id = kwargs["reaction_id"]
         parameters_in_kinetic_law_only = kwargs["parameters_in_kinetic_law_only"]
         non_constant_params = kwargs["non_constant_params"]
-        if len(non_constant_params) > 0:
-            non_constant_params = ",".join(non_constant_params)
+        non_constant_params_in_kinetic_law = []
+        for param in parameters_in_kinetic_law_only:
+            if param in non_constant_params:
+                non_constant_params_in_kinetic_law.append(param)
+        if len(non_constant_params_in_kinetic_law) > 0:
+            non_constant_params_in_kinetic_law = ",".join(non_constant_params_in_kinetic_law)
             self.results.add_message(
-                reaction_id, 1006, f"Expecting these parameters to be constants: {non_constant_params}")
+                reaction_id, 1006, f"Expecting these parameters to be constants: {non_constant_params_in_kinetic_law}")
 
     def _check_irreversibility(self, **kwargs):
         """