Add recipe for FOSUserBundle #270

tattali · 2018-02-01T07:44:58Z

Q	A
License	MIT

ghost

Pull request does not pass validation.

…fsymfony/user-bundle/2.1.x-dev/post-install.txt

ghost

Pull request does not pass validation.

ghost

Pull request does not pass validation.

ghost

Pull request passes validation.

Nyholm

Looks good. Ping me when 2.1 is released and I'll be happy to merge.

tattali · 2018-02-05T02:42:04Z

Thanks I will

ghost

Pull request passes validation.

covex-nn · 2018-02-05T15:23:49Z

friendsofsymfony/user-bundle/2.1/config/packages/fos_user.yaml

+    user_class: App\Entity\User
+    from_email:
+        address: "address"
+        sender_name: "name"


@tattali FOSUserBundle can be used without templating service. Add this to use twig directly:

fos_user: service: mailer: fos_user.mailer.twig_swift

It can be used even without mailer service, if a bug will be fixed (PR is not accepted/merged yet). See FriendsOfSymfony/FOSUserBundle#2707 and FriendsOfSymfony/FOSUserBundle#2704

Ok sorry when I did the search I did not see your recipe. If you want we can use yours that looks more accomplished.

There is no my recipe as there is no v2.1 release yet =) And it is not possible to create recipe right now, because even with new fos_user.service.mailer parameter, FOSUB will require doctrine-bundle for fos_user.db_driver: orm. I've created PR FriendsOfSymfony/FOSUserBundle#2708 ~~~but they ignore me =)~~~

ghost

Pull request passes validation.

Nyholm

Thank you for this PR. Can you make sure Travis is happy?

tattali · 2018-02-26T14:13:57Z

For now it's impossible to create a recipe for this bundle because it's necessary to install an orm (that you choose) and swiftmailer separately.
As long as these two problems are not resolved the travis test will make it wrong.

ghost

Pull request passes validation.

Nyholm · 2018-06-22T16:35:33Z

Can you make sure travis is happy?

tattali · 2018-07-01T18:17:25Z

This recipe work only on symfony/website-skeleton and not on symfony/skeleton.
Travis can't be happy from now.
A mailer is needed at the installation of the bundle.
But they won't choose between available mailer or make us disable the needs of the mailer if no one are installed.

tattali · 2018-07-03T08:40:05Z

If you want to see a recipe for FOSUserBundle take a look and show your support by 👍 on :
FriendsOfSymfony/FOSUserBundle#2708 (comment)

ghost

Pull request passes validation.

ghost

Pull request does not pass validation.

ghost

Pull request passes validation.

maxhelias

Just a little change but it looks good while waiting for compatibility so that Travis is happy.

By the way, could you update the post-install.txt file accordingly

maxhelias · 2018-08-15T14:53:34Z

friendsofsymfony/user-bundle/2.1/config/packages/fos_user.yaml

+        mailer: fos_user.mailer.noop
+    firewall_name: main
+    user_class: App\Entity\User
+    from_email:


Can you use that :

from_email: address: '%env(MAILER_SENDER_ADDRESS)%' sender_name: '%env(MAILER_SENDER_NAME)%'

maxhelias · 2018-08-15T14:55:01Z

friendsofsymfony/user-bundle/2.1/config/routes/fos_user.yaml

@@ -0,0 +1,18 @@
+fos_user_security:


Why you didn't load the routes like that ?

fos_user: resource: '@FOSUserBundle/Resources/config/routing/all.xml'

People may not need every routes

You're right, it seems good to me 👍
I can not wait to see this merged

me too I hope this PR FriendsOfSymfony/FOSUserBundle#2708 will be merged soon

maxhelias · 2018-08-15T14:57:13Z

friendsofsymfony/user-bundle/2.1/manifest.json

+    "copy-from-recipe": {
+        "config/": "%CONFIG_DIR%/",
+        "src/": "%SRC_DIR%/"
+    }


Add the env var

, "env": { "MAILER_SENDER_ADDRESS": "[email protected]", "MAILER_SENDER_NAME": "John Doe" }

maxhelias · 2018-08-15T15:04:29Z

friendsofsymfony/user-bundle/2.1/config/packages/fos_user.yaml

@@ -0,0 +1,9 @@
+fos_user:
+    db_driver: orm
+    service:


Can you move service block between user_class and from_email for more readability please?

maxhelias · 2018-08-15T15:09:35Z

friendsofsymfony/user-bundle/2.1/src/Entity/User.php

+{
+    /**
+     * @ORM\Column(type="integer")
+     * @ORM\Id


Can you switch order with line above please

This entity is maybe going to disappear because it's a doctrine orm entity and not mongo or couchdb

ghost

Pull request passes validation.

Nyholm

Thank you. This looks good.

#eu-fossa

Devolicious · 2019-04-09T14:18:21Z

@Nyholm @tattali The build failed for this PR. It includes config that is not supported (yet) by FOSUserBundle and now results in an error when you install the package. The PR for support of the no_driver is still ongoing at FriendsOfSymfony/FOSUserBundle#2708. This should not have been merged imho.

Nyholm · 2019-04-09T14:21:01Z

Oh, @Devolicious, you might be correct. Do you want to "correct" this PR or what is the status on the no_driver?

Devolicious · 2019-04-09T14:32:04Z

@Nyholm For the time being I don't think there is any good solution except reverting this PR because the driver needs to be set and if you choose one of the supported drivers you need to have the corresponding packages as well which also breaks the build/install process if you do not have it installed. That's the main reason why they created the no_driver option but it is heavily debated it seems. Not sure why the discussion halted somewhere in august as the PR is approved but not merged.

Devolicious · 2019-04-09T14:40:25Z

@maxhelias Can you give some more insight into this problem?

maxhelias · 2019-04-09T21:32:44Z

@Devolicious In fact, FOSUserbundle does not depend on DoctrinBundle, but the db_driver option in the recipe requires another recipe to work properly as orm or mongodb.
The solution would be to revert the merge and wait for the merger of no_driver

Devolicious · 2019-04-10T08:42:08Z

@Nyholm can you revert this PR?

It was merge prematurely. Reverting symfony#270

Nyholm · 2019-04-11T12:27:22Z

@Devolicious, See #655

Initially added in symfony#270 and reverted in symfony#655

Add recipe for FOSUserBundle

db02850

ghost suggested changes Feb 1, 2018

View reviewed changes

Rename friendsofsymfony/user-bundle/@dev/post-install.txt to friendso…

7e5d3ec

…fsymfony/user-bundle/2.1.x-dev/post-install.txt

ghost suggested changes Feb 1, 2018

View reviewed changes

rename to 2.1.x-dev version

e123d02

ghost suggested changes Feb 1, 2018

View reviewed changes

rename to 2.1 version

f5c0597

ghost deployed to staging February 1, 2018 08:00 View deployment

ghost approved these changes Feb 1, 2018

View reviewed changes

Nyholm reviewed Feb 4, 2018

View reviewed changes

Update post-install.txt

f1f2b70

ghost deployed to staging February 5, 2018 15:12 View deployment

ghost approved these changes Feb 5, 2018

View reviewed changes

covex-nn reviewed Feb 5, 2018

View reviewed changes

Update fos_user.yaml

dfb8b22

ghost deployed to staging February 6, 2018 14:59 View deployment

ghost approved these changes Feb 6, 2018

View reviewed changes

Nyholm requested changes Feb 25, 2018

View reviewed changes

Nyholm mentioned this pull request Feb 25, 2018

[WIP] Add recipe for friendsofsymfony/user-bundle #210

Closed

This was referenced Apr 12, 2018

WIP FOSUserBundle 2.1 #344

Closed

Add FOS User Bundle recipe #345

Closed

patrickbussmann added a commit to patrickbussmann/recipes-contrib that referenced this pull request May 16, 2018

Added recipe for FOSUserBundle (symfony#345 symfony#270)

78221a4

patrickbussmann mentioned this pull request May 16, 2018

Added recipe for FOSUserBundle (#345 #270) #363

Closed

Update post-install.txt

53c9524

ghost deployed to staging June 3, 2018 22:42 View deployment

ghost approved these changes Jun 3, 2018

View reviewed changes

Nyholm mentioned this pull request Jun 26, 2018

How to Build a Traditional Login Form refers viewers to FOSUserBundle symfony/symfony-docs#9946

Closed

Update fos_user.yaml

176e34b

ghost deployed to staging July 3, 2018 09:36 View deployment

ghost approved these changes Jul 3, 2018

View reviewed changes

ghost suggested changes Jul 15, 2018

View reviewed changes

ghost deployed to staging July 29, 2018 18:05 View deployment

ghost approved these changes Jul 29, 2018

View reviewed changes

maxhelias reviewed Aug 15, 2018

View reviewed changes

maxhelias mentioned this pull request Aug 15, 2018

FOSUserBundle recipe #452

Closed

use no_driver parameter and modify post-install.txt

9bd9382

ghost deployed to staging August 16, 2018 15:01 View deployment

ghost approved these changes Aug 16, 2018

View reviewed changes

fabpot mentioned this pull request Sep 3, 2018

WIP: Add fosuserbundle recipe. #343

Closed

Nyholm approved these changes Apr 6, 2019

View reviewed changes

ghost merged commit 9bd9382 into symfony:master Apr 6, 2019

ghost pushed a commit that referenced this pull request Apr 6, 2019

Merge pull request #270

69db426

Nyholm added a commit to Nyholm/recipes-contrib that referenced this pull request Apr 11, 2019

Remove recipe for FOSUserBundle

3ba633b

It was merge prematurely. Reverting symfony#270

Nyholm mentioned this pull request Apr 11, 2019

Remove recipe for FOSUserBundle #655

Merged

Nyholm added a commit to Nyholm/recipes-contrib that referenced this pull request Apr 11, 2019

Adding back FosUserBundle

20cc3cb

Initially added in symfony#270 and reverted in symfony#655

Nyholm mentioned this pull request Apr 11, 2019

WIP: Reintroduce FOSUserBundle #656

Closed

Nyholm added a commit to Nyholm/recipes-contrib that referenced this pull request Apr 11, 2019

Adding back FosUserBundle

92b08ad

Initially added in symfony#270 and reverted in symfony#655

This pull request was closed.

Add recipe for FOSUserBundle #270

Add recipe for FOSUserBundle #270

Conversation

tattali commented Feb 1, 2018

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

Nyholm left a comment

Choose a reason for hiding this comment

tattali commented Feb 5, 2018

ghost left a comment

Choose a reason for hiding this comment

covex-nn Feb 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

covex-nn Feb 6, 2018 • edited Loading

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

Nyholm left a comment

Choose a reason for hiding this comment

tattali commented Feb 26, 2018

ghost left a comment

Choose a reason for hiding this comment

Nyholm commented Jun 22, 2018

tattali commented Jul 1, 2018

tattali commented Jul 3, 2018

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

maxhelias left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tattali Aug 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tattali Aug 16, 2018 • edited Loading

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

Nyholm left a comment

Choose a reason for hiding this comment

Devolicious commented Apr 9, 2019

Nyholm commented Apr 9, 2019

Devolicious commented Apr 9, 2019

Devolicious commented Apr 9, 2019

maxhelias commented Apr 9, 2019 • edited Loading

Devolicious commented Apr 10, 2019

Nyholm commented Apr 11, 2019

covex-nn Feb 5, 2018 •

edited

Loading

covex-nn Feb 6, 2018 •

edited

Loading

tattali Aug 16, 2018 •

edited

Loading

tattali Aug 16, 2018 •

edited

Loading

maxhelias commented Apr 9, 2019 •

edited

Loading