-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add fosuserbundle recipe. #343
WIP: Add fosuserbundle recipe. #343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
@@ -0,0 +1,7 @@ | |||
fos_user: | |||
db_driver: orm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indendation must be a multiple of 4 blanks
@@ -0,0 +1,7 @@ | |||
fos_user: | |||
db_driver: orm | |||
user_class: App\Entity\User |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indendation must be a multiple of 4 blanks
fos_user: | ||
db_driver: orm | ||
user_class: App\Entity\User | ||
firewall_name: main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indendation must be a multiple of 4 blanks
db_driver: orm | ||
user_class: App\Entity\User | ||
firewall_name: main | ||
from_email: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indendation must be a multiple of 4 blanks
"config/": "%CONFIG_DIR%/", | ||
"src/": "%SRC_DIR%/" | ||
}, | ||
"env': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid character '\n' in string literal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request does not pass validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request passes validation.
I was making this for a hobby and learning how recipes work. During DrupalCon I talked to @weaverryan and @nicolas-grekas and this one is most likely to not pass; so, feel free to close it if it's convenient :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
|
||
/* | ||
public function findBySomething($value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not use commented code like this
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository; | ||
use Symfony\Bridge\Doctrine\RegistryInterface; | ||
|
||
class UserRepository extends ServiceEntityRepository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a UserRepository
* @ORM\GeneratedValue | ||
* @ORM\Column(type="integer") | ||
*/ | ||
protected $id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be private?
Any updates here? |
Closing as a duplicate (#270) |
Hi there,
I'd like to help to create the fosuserbundle recipe.
Right now, I have 2 blockers:
I'd appreciate any help and guidance you can provide me.
Btw, thanks for creating such great tools!