Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add fosuserbundle recipe. #343

Closed

Conversation

kporras07
Copy link

@kporras07 kporras07 commented Apr 11, 2018

Q A
License MIT

Hi there,

I'd like to help to create the fosuserbundle recipe.

Right now, I have 2 blockers:

I'd appreciate any help and guidance you can provide me.

Btw, thanks for creating such great tools!

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@@ -0,0 +1,7 @@
fos_user:
db_driver: orm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indendation must be a multiple of 4 blanks

@@ -0,0 +1,7 @@
fos_user:
db_driver: orm
user_class: App\Entity\User
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indendation must be a multiple of 4 blanks

fos_user:
db_driver: orm
user_class: App\Entity\User
firewall_name: main
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indendation must be a multiple of 4 blanks

db_driver: orm
user_class: App\Entity\User
firewall_name: main
from_email:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indendation must be a multiple of 4 blanks

"config/": "%CONFIG_DIR%/",
"src/": "%SRC_DIR%/"
},
"env': {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid character '\n' in string literal

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@kporras07
Copy link
Author

I was making this for a hobby and learning how recipes work. During DrupalCon I talked to @weaverryan and @nicolas-grekas and this one is most likely to not pass; so, feel free to close it if it's convenient :)

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
It seams to be a duplicate of #270 and #345.

}

/*
public function findBySomething($value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use commented code like this

use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Symfony\Bridge\Doctrine\RegistryInterface;

class UserRepository extends ServiceEntityRepository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need a UserRepository

* @ORM\GeneratedValue
* @ORM\Column(type="integer")
*/
protected $id;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be private?

@Nyholm
Copy link
Member

Nyholm commented Jun 22, 2018

Any updates here?

@maxhelias maxhelias mentioned this pull request Aug 15, 2018
@fabpot
Copy link
Member

fabpot commented Sep 3, 2018

Closing as a duplicate (#270)

@fabpot fabpot closed this Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants