Remove OpenStruct usage #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading the gem on Ruby 3.3.5 or 3.4.0-preview1 prints this warning:
lib/jira-ruby.rb:53: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
OpenStruct is used to store two values, field_map and field_map_reverse,
but only field_map was used, so we can store it directly in an instance
variable and remove the dependency on OpenStruct.
bobbrodie
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
@eugeneius this is great, thanks! I'll merge and get it into 3.0.0-beta2. Before I push that, I'll work on cleaning up the RSpec/StringAsInstanceDoubleConstant checks.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the gem on Ruby 3.3.5 or 3.4.0-preview1 prints this warning:
OpenStruct is used to store two values (
field_mapandfield_map_reverse) but onlyfield_mapwas actually used, so we can store it directly in an instance variable and remove the dependency on OpenStruct.