Rubocop updates #455
Merged
Rubocop updates #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a ton of cops disabled a while ago so we could implement Rubocop over time. I noticed that removing Openstruct usage in #454 resulted in some already existing issues bubbling up. This was not because of the changes in that PR, but rather stopping the cop from being disabled let us see. While cleaning that up, I tackled a few others.
The following have been re-enabled and the corresponding code cleaned up:
Re-enabling
RSpec/SpecFilePathSuffixwas an important one because I discovered that thewebhookspec was not running because its filename was missing_spec. Once enabled, I realized there was an issue with the REST path when it included/1.0/.