Skip to content
This repository has been archived by the owner on Jul 29, 2021. It is now read-only.

added formatter #43

Merged
merged 2 commits into from
Feb 6, 2021
Merged

added formatter #43

merged 2 commits into from
Feb 6, 2021

Conversation

ma7dev
Copy link
Contributor

@ma7dev ma7dev commented Feb 6, 2021

Added Prettier package as a development dependecy in the project that will auto-format the entire project.
During development, use npm run dev, which will run prettier on the project then run nodemon to run the project for development.
During deployment, use npm run dep, which will run prettier on the project then run pm2 to run a background process of the project for deployment.
To stop the nodejs server during deployment, use npm run stop to stop the pm2 background process of the project.

Added Prettier package as a development dependecy in the project that will auto-format the entire project.
During development, use `npm run dev`, which will run prettier on the project then run nodemon to run the project for development.
During deployment, use `npm run dep`, which will run prettier on the project then run pm2 to run a background process of the project for deployment.
To stop the nodejs server during deployment, use `npm run stop` to stop the pm2 background process of the project.
@ma7dev ma7dev linked an issue Feb 6, 2021 that may be closed by this pull request
Copy link
Collaborator

@grepaziz grepaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simple mistakes

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Per @grepaziz's review, I needed to update package.json in order to work across different machines. He tried to run `npm run dev`
but couldn't due to the command was special for unix/linux environments.
@ma7dev ma7dev requested review from grepaziz and removed request for MutlaqAldhbuiub February 6, 2021 19:05
Copy link
Collaborator

@grepaziz grepaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job maze

@ma7dev ma7dev merged commit c9876c1 into main Feb 6, 2021
@ma7dev ma7dev deleted the formatting branch February 6, 2021 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding GitHub Actions
2 participants