Skip to content
This repository has been archived by the owner on Jul 29, 2021. It is now read-only.

Adding GitHub Actions #30

Closed
ma7dev opened this issue Oct 10, 2020 · 6 comments · Fixed by #43, #56, #57 or #65
Closed

Adding GitHub Actions #30

ma7dev opened this issue Oct 10, 2020 · 6 comments · Fixed by #43, #56, #57 or #65
Labels
delay enhancement New feature or request

Comments

@ma7dev
Copy link
Contributor

ma7dev commented Oct 10, 2020

Is your feature request related to a problem? Please describe.
As we develop further, we can't manually test our PR so we would need to have some unit tests like scripts.

Describe the solution you'd like
Implementing a template for test commands with expected parameters and have the ability to add more unit tests.

@ma7dev ma7dev added the enhancement New feature or request label Oct 10, 2020
@ma7dev ma7dev changed the title Adding CLI Adding CI Oct 31, 2020
@ma7dev ma7dev linked a pull request Oct 31, 2020 that will close this issue
@ma7dev
Copy link
Contributor Author

ma7dev commented Oct 31, 2020

To implement CI, we would need to refactor the source code to be more encapsulated as classes of objects rather than sequential code. Look for https://github.com/ashindlecker/tdd-discord-music-bot for reference.

I will continue working on this next Saturday or so to refactor the code fully and add CI (CircleCI and CodeCov) for automated building and testing (including unit and coverage testing)

@ma7dev
Copy link
Contributor Author

ma7dev commented Nov 3, 2020

Need to refactor the commands folder to have subdirectories for a more organized code structure. In addition, refactor the code of every command to include output option (passed as a parameter) in order to unit test when needed.

@ma7dev ma7dev changed the title Adding CI Adding GitHub Actions Nov 9, 2020
@ma7dev ma7dev added the delay label Jan 31, 2021
@ma7dev
Copy link
Contributor Author

ma7dev commented Feb 5, 2021

I will be implementing CI for auto-formatting for uniform formating.

@ma7dev ma7dev linked a pull request Feb 6, 2021 that will close this issue
@ma7dev ma7dev closed this as completed in #43 Feb 6, 2021
@ma7dev ma7dev reopened this Feb 6, 2021
@ma7dev
Copy link
Contributor Author

ma7dev commented Feb 16, 2021

Need to implement those github actions:

  • Build on OS
    • Linux
    • Mac
    • Windows
  • Unit tests
    • Commands
    • Database
  • Code coverage

@ma7dev ma7dev linked a pull request Feb 21, 2021 that will close this issue
@ma7dev ma7dev reopened this Feb 21, 2021
@ma7dev
Copy link
Contributor Author

ma7dev commented Feb 21, 2021

Need to add GitHub CI, Code coverage, and different builds on different OS's.

@ma7dev ma7dev linked a pull request Feb 22, 2021 that will close this issue
@ma7dev ma7dev mentioned this issue Feb 22, 2021
@ma7dev
Copy link
Contributor Author

ma7dev commented Feb 23, 2021

  • CI still doesn't work on Windows and MacOS
  • Need to build the docs using CI and move it to the repo
  • Add database tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
delay enhancement New feature or request
Projects
None yet
1 participant