Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variants bugs #1 #484

Merged
merged 17 commits into from
Oct 16, 2024
Merged

Fix variants bugs #1 #484

merged 17 commits into from
Oct 16, 2024

Commits on Oct 10, 2024

  1. fix: remove the witness only when there is 'witnesses' html element i… 

    …n text panel
    malkja committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7483b5f View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. fix: restructure addWitness() to avoid the bug when target is the onl… 

    …y child of its parent
    malkja committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    bfbad91 View commit details
    Browse the repository at this point in the history

  2. fix: add checks on witnesses array to avoid bugs

    malkja committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0ed85e6 View commit details
    Browse the repository at this point in the history

  3. fix: remove bug when target is null

    malkja committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2348a48 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. fix: show the variants top bar only when there are filteredAnnotation… 

    …s for the variants tab
    malkja committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    29107b5 View commit details
    Browse the repository at this point in the history

  2. fix: do not emit a click on text, when it is not an annotation target

    malkja committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    cece57d View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. refactor: improve the code which updates the parentHtml el when we ad… 

    …d a witness
    malkja committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ac3da6c View commit details
    Browse the repository at this point in the history

  2. refactor: add early return statement in allocateWitnessColorInVariant… 

    …Item
    malkja committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2d17820 View commit details
    Browse the repository at this point in the history

  3. chore: remove the if condition on showing the witnesses filter

    malkja committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    3411f65 View commit details
    Browse the repository at this point in the history

  4. refactor: clean addWitness() function

    malkja committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    254d2cb View commit details
    Browse the repository at this point in the history

  5. refactor: check the existence of witnesses Html in removeWitness()

    malkja committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    0dc91d7 View commit details
    Browse the repository at this point in the history

  6. refactor: add early return in getWitnessesHtmlEl()

    malkja committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    aa0d73d View commit details
    Browse the repository at this point in the history

  7. refactor: restructure better addWitness and remove 'html' from variab… 

    …le names
    malkja committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4bdc524 View commit details
    Browse the repository at this point in the history

  8. refactor: remove unused functions and added checks on (null or zero-l… 

    …ength) arrays
    malkja committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    244210b View commit details
    Browse the repository at this point in the history

  9. docs: reason why witnesses wrapper is on the same child level as targ… 

    …et in addWitnesses()
    malkja committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c3c7abd View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. refactor: make createWitnessEl function consistent

    malkja committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6ac640b View commit details
    Browse the repository at this point in the history

  2. refactor: make several functions in annotations.js more consistent

    malkja committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d90b225 View commit details
    Browse the repository at this point in the history