Fix variants bugs #1 #484
Merged
Fix variants bugs #1 #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 10, 2024 12:40
…y child of its parent
…s for the variants tab
paulpestov
reviewed
Oct 14, 2024
| @@ -61,10 +61,12 @@ onBeforeUnmount(() => unsubscribe()) | |||
|
|
|||
| function allocateWitnessColorInVariantItem() { | |||
| const colors = {} | |||
| annotationStore.witnesses.forEach((witness, i) => { | |||
| if(annotationStore.witnesses?.length > 0) { | |||
There was a problem hiding this comment.
Please use "early return" pattern, since wrapping an "if" around some code is kind of ugly
src/stores/annotations.ts
Outdated
|
|
||
| if (!target) { | ||
| if (!target || target.getAttribute('data-annotation-level') < 0) { |
There was a problem hiding this comment.
We identified today that this wasn't really the issue of the bug. So this is not needed anymore I guess.
src/utils/annotations.js
Outdated
| let witnessesHtmlEl = parentEl.children[indexOfTarget-1] | ||
| witnessesHtmlEl.appendChild(witHtml) | ||
| } | ||
| } | ||
|
|
||
| function createWitnessesHtml(witHtml, parentEl, targetHtmlEl) { | ||
| const witnessesHtmlEl = document.createElement("span"); | ||
| witnessesHtmlEl.classList.add('witnesses') |
There was a problem hiding this comment.
You can omit the words"witnessesHtml" if those are already in your function name (btw this applies also for classes or components). Call it "resultEl" or just "el", it will be fine.
added 6 commits
October 15, 2024 14:08
orlinmalkja
force-pushed
the
fix-variants-bugs
branch
from
76364d1
to
aa0d73d
Compare
|
For now, I am done with this PR. Please continue reviewing. |
added 2 commits
October 15, 2024 16:28
|
@paulpestov from my side I am done with this PR. Please continue reviewing. |
paulpestov
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.