Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Docusign rule to reduce false positives. #1083

Merged
merged 4 commits into from
Dec 5, 2023
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ severity: "high"
source: |
type.inbound
and length(attachments) <= 1
and any(body.links,
and all(body.links,
aslefhewqiwbepqwefbpqsciwueh marked this conversation as resolved.
Show resolved Hide resolved
not strings.ilike(.href_url.domain.root_domain, "docusign.*")
)
and (
Expand Down Expand Up @@ -34,6 +34,10 @@ source: |
and not profile.by_sender().any_false_positives
)
)

//negate sender from Docusign
and not strings.like(sender.email.domain.root_domain, "docusign.com")

aslefhewqiwbepqwefbpqsciwueh marked this conversation as resolved.
Show resolved Hide resolved
// negate highly trusted sender domains unless they fail DMARC authentication
and
(
Expand Down
Loading