Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Docusign rule to reduce false positives. #1083

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

aslefhewqiwbepqwefbpqsciwueh
Copy link
Contributor

Hi,

This rule was causing false positives with docusign marketing emails. I suggest two changes.

Check all the links for docusign domain instead of any:

and all(body.links,
          not strings.ilike(.href_url.domain.root_domain, "docusign.*")
  )

Check the sender is not Docusign itself:

and not strings.like(sender.email.domain.root_domain, "docusign.com")

Many thanks!

Copy link
Member

@morriscode morriscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aslefhewqiwbepqwefbpqsciwueh
Looks great, much appreciated!

@morriscode morriscode merged commit 7a48130 into sublime-security:main Dec 5, 2023
3 checks passed
@aslefhewqiwbepqwefbpqsciwueh
Copy link
Contributor Author

Many thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants