Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more testing, remove redundant #772

Merged
merged 18 commits into from
Oct 17, 2023
Merged

Add more testing, remove redundant #772

merged 18 commits into from
Oct 17, 2023

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Sep 12, 2023 •
edited
Loading

Closes #764 & #794

summary

Adds more testing for critical pieces of which are not used anywhere else in interchaintest.
Test removed (ex: PFM) are linked to other outside repos

other minor additions

  • cosmos.SetSDKConfig(bech32) now sets the config of a running container for proper addr parsing
  • RangeBlockMessages was made public
  • NewGenesisKV for cleaner genesis items

what this does not include

  • gov proposals (sdk v50 parse issues, wasmd does not yet support)
  • wasm (steve's Compile PR handles)

@Reecepbcups Reecepbcups marked this pull request as ready for review September 19, 2023 14:18
@Reecepbcups Reecepbcups requested a review from a team as a code owner September 19, 2023 14:18
@Reecepbcups Reecepbcups enabled auto-merge (squash) September 19, 2023 19:42
@Reecepbcups Reecepbcups mentioned this pull request Oct 2, 2023
Merged
@Reecepbcups Reecepbcups changed the title Add more testing Add more testing, remove redundant Oct 4, 2023
@Reecepbcups Reecepbcups linked an issue Oct 4, 2023 that may be closed by this pull request
Remove complex example test #794
Closed
@Reecepbcups Reecepbcups marked this pull request as draft October 4, 2023 15:36
auto-merge was automatically disabled October 4, 2023 15:36

Pull request was converted to draft

@Reecepbcups Reecepbcups marked this pull request as ready for review October 4, 2023 16:08
@Reecepbcups Reecepbcups mentioned this pull request Oct 8, 2023
Closed
boojamya
boojamya approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge cleanup!
The tests added in miscellaneous are what we needed.

Hopefully we can get those removed tests that you created gists for into ibc-apps sooner than later.

One question for my own sanity, but approved.

examples/cosmos/chain_miscellaneous_test.go Show resolved Hide resolved
@boojamya boojamya mentioned this pull request Oct 16, 2023
Merged
@Reecepbcups Reecepbcups enabled auto-merge (squash) October 16, 2023 18:29
@Reecepbcups Reecepbcups added the BACKPORT backport into all maintained branches label Oct 16, 2023
@Reecepbcups Reecepbcups merged commit 8caf914 into main Oct 17, 2023
9 checks passed
@Reecepbcups Reecepbcups deleted the reece/more-cosmos-test branch October 17, 2023 13:49
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
@Reecepbcups @mergify
Add more testing, remove redundant (#772)
29fce38 
* Add a "misc" test example for cosmos_node

* backup: wip (adding node, wallet keys, sending, FindTxs, and PollForBal)

* enable more and cleanup

* feat: SetSDKConfig(bech32prefix) for configuration

* testBroadcaster with bank multimsg send

* qol: NewGenesisKV(key, value)

* more wallet checks

* queryCmd, HashCommand

* rm duplicate test, add outside references

* rm SDK 45 test, same logic applies to 47

* Add light client verification to the IBC example

* Add more IBC examples

* fix: wasm icq StartupFlags

* Add more buffer to the conformance test

(cherry picked from commit 8caf914)

# Conflicts:
#	examples/cosmos/chain_miscellaneous_test.go
#	examples/cosmos/light_client_test.go
#	examples/cosmos/state_sync_test.go
#	examples/ibc/interchain_accounts_test.go
#	examples/ibc/interchain_queries_test.go
#	examples/ibc/learn_ibc_test.go
#	examples/ibc/packet_forward_test.go
@mergify mergify bot mentioned this pull request Oct 17, 2023
Merged
Reecepbcups added a commit that referenced this pull request Oct 17, 2023
@mergify @Reecepbcups
[BP: v7 <- #772] Add more testing, remove redundant (#828)
dd072db 
* Add more testing, remove redundant (#772)

* Add a "misc" test example for cosmos_node

* backup: wip (adding node, wallet keys, sending, FindTxs, and PollForBal)

* enable more and cleanup

* feat: SetSDKConfig(bech32prefix) for configuration

* testBroadcaster with bank multimsg send

* qol: NewGenesisKV(key, value)

* more wallet checks

* queryCmd, HashCommand

* rm duplicate test, add outside references

* rm SDK 45 test, same logic applies to 47

* Add light client verification to the IBC example

* Add more IBC examples

* fix: wasm icq StartupFlags

* Add more buffer to the conformance test

(cherry picked from commit 8caf914)

# Conflicts:
#	examples/cosmos/chain_miscellaneous_test.go
#	examples/cosmos/light_client_test.go
#	examples/cosmos/state_sync_test.go
#	examples/ibc/interchain_accounts_test.go
#	examples/ibc/interchain_queries_test.go
#	examples/ibc/learn_ibc_test.go
#	examples/ibc/packet_forward_test.go

* fix merge -> `v7`

---------

Co-authored-by: Reece Williams <[email protected]>
Co-authored-by: Reece Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojamya boojamya boojamya approved these changes

Assignees
No one assigned
Labels
BACKPORT backport into all maintained branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove complex example test Add more chain examples & further testing with it
2 participants
@Reecepbcups @boojamya