Simplify verbose boilerplate builder #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boojamya
reviewed
Oct 16, 2023
|
yea I had planned to get this PR in first, then merge in the removal of test after just to validate all new helper functions worked as expected |
boojamya
approved these changes
Oct 16, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* qol: NewGenesisKV(key, value) * RegisterInterfaces, CreateChainWithConfig, BuildInitialChain * migrate examples to new functions ^^ * Add BuildChainWithRelayer abstraction * Migrate examples to the new format * 2 unique chainSpecs * stop relayer on cleanup * if links != nil, setup relayer * stop relayer only if it was set (cherry picked from commit 2c47fa0) # Conflicts: # examples/ibc/interchain_accounts_test.go
Reecepbcups
added a commit
that referenced
this pull request
Oct 17, 2023
* Simplify verbose boilerplate builder (#773) * qol: NewGenesisKV(key, value) * RegisterInterfaces, CreateChainWithConfig, BuildInitialChain * migrate examples to new functions ^^ * Add BuildChainWithRelayer abstraction * Migrate examples to the new format * 2 unique chainSpecs * stop relayer on cleanup * if links != nil, setup relayer * stop relayer only if it was set (cherry picked from commit 2c47fa0) # Conflicts: # examples/ibc/interchain_accounts_test.go * fix imports * v7 imports --------- Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #771, #151
summary
This removes a lot of excess testing boilerplate for common setups. (Juno & PersistenceOne both use)