Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors and coding in header Backup book #7302

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Build errors and coding in header Backup book #7302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions business_continuity/backup_restore/backup_validate.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@ The following templates check the pod status for the backup component and depend
+
* `backup-storage-location-available` template checks if a `BackupStorageLocation.velero.io` resource is created and if the status value is `Available`. This implies that the connection to the backup storage is valid.
- *BackupSchedule collision validation*
- *`BackupSchedule` collision validation*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are using these as they are coded, we need to reflect that. When translated, the other party would not know this is part of a code function and would not recognize this as a word. That is why we either use the general term "backup schedule" or we code it as it is in the product.

No hard rule about which you choose, other than have it reflect the purpose of the content.

+
* `acm-backup-clusters-collision-report` template verifies that the status is not `BackupCollision`, if a `BackupSchedule.cluster.open-cluster-management.io` exists on the current hub cluster. This verifies that the current hub cluster is not in collision with any other hub cluster when you write backup data to the storage location.
+
For a definition of the `BackupCollision`, see xref:../backup_restore/backup_schedule.adoc#avoid-backup-collision[Avoiding backup collisions].
For a definition of the `BackupCollision`, see xref:../backup_restore/backup_schedule.adoc#prevent-backup-collision[Preventing backup collisions].
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what caused the error and I think you changed it to "prevent" but please check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link passed local test.

- *BackupSchedule and restore status validation*
- *`BackupSchedule` and restore status validation*
+
* `acm-backup-phase-validation` template checks that the status is not in `Failed`, or `Empty` state, if a `BackupSchedule.cluster.open-cluster-management.io` exists on the current cluster. This ensures that if this cluster is the primary hub cluster and is generating backups, the `BackupSchedule.cluster.open-cluster-management.io` status is healthy.
* The same template checks that the status is not in a `Failed`, or `Empty` state, if a `Restore.cluster.open-cluster-management.io` exists on the current cluster. This ensures that if this cluster is the secondary hub cluster and is restoring backups, the `Restore.cluster.open-cluster-management.io` status is healthy.
Expand Down
2 changes: 1 addition & 1 deletion release_notes/acm_whats_new.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ See link:../governance/grc_intro.adoc#governance[Governance] to learn more about

* You can now customize the OADP version by setting an annotation on your `MultiClusterHub` resource. See link:../business_continuity/backup_restore/backup_install.adoc#installing-custom-oadp[Installing a custom OADP version].

* You can now temporarily pause the `BackupSchedule` resource instead of deleting it. By using the `BackupSchedule` `paused` property on the backup hub cluster, you can avoid a backup collision. See link:../business_continuity/backup_restore/backup_schedule.adoc#avoid-backup-collision[Avoiding backup collisions].
* You can now temporarily pause the `BackupSchedule` resource instead of deleting it. By using the `BackupSchedule` `paused` property on the backup hub cluster, you can avoid a backup collision. See link:../business_continuity/backup_restore/backup_schedule.adoc#prevent-backup-collision[Preventing backup collisions].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what caused the error and I think you changed it to "prevent" but please check.

* You can now keep the primary hub cluster active during a restore operation. See link:../business_continuity/backup_restore/backup_active_restore.adoc#keep-hub-active-restore[Keeping the primary hub cluster active during a restore process].

Expand Down
Loading