Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors and coding in header Backup book #7302

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

swopebe
Copy link
Contributor

@swopebe swopebe commented Dec 2, 2024

No description provided.

@@ -36,13 +36,13 @@ The following templates check the pod status for the backup component and depend
+
* `backup-storage-location-available` template checks if a `BackupStorageLocation.velero.io` resource is created and if the status value is `Available`. This implies that the connection to the backup storage is valid.

- *BackupSchedule collision validation*
- *`BackupSchedule` collision validation*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are using these as they are coded, we need to reflect that. When translated, the other party would not know this is part of a code function and would not recognize this as a word. That is why we either use the general term "backup schedule" or we code it as it is in the product.

No hard rule about which you choose, other than have it reflect the purpose of the content.

@@ -118,7 +118,7 @@ See link:../governance/grc_intro.adoc#governance[Governance] to learn more about

* You can now customize the OADP version by setting an annotation on your `MultiClusterHub` resource. See link:../business_continuity/backup_restore/backup_install.adoc#installing-custom-oadp[Installing a custom OADP version].

* You can now temporarily pause the `BackupSchedule` resource instead of deleting it. By using the `BackupSchedule` `paused` property on the backup hub cluster, you can avoid a backup collision. See link:../business_continuity/backup_restore/backup_schedule.adoc#avoid-backup-collision[Avoiding backup collisions].
* You can now temporarily pause the `BackupSchedule` resource instead of deleting it. By using the `BackupSchedule` `paused` property on the backup hub cluster, you can avoid a backup collision. See link:../business_continuity/backup_restore/backup_schedule.adoc#prevent-backup-collision[Preventing backup collisions].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what caused the error and I think you changed it to "prevent" but please check.

+
* `acm-backup-clusters-collision-report` template verifies that the status is not `BackupCollision`, if a `BackupSchedule.cluster.open-cluster-management.io` exists on the current hub cluster. This verifies that the current hub cluster is not in collision with any other hub cluster when you write backup data to the storage location.
+
For a definition of the `BackupCollision`, see xref:../backup_restore/backup_schedule.adoc#avoid-backup-collision[Avoiding backup collisions].
For a definition of the `BackupCollision`, see xref:../backup_restore/backup_schedule.adoc#prevent-backup-collision[Preventing backup collisions].
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what caused the error and I think you changed it to "prevent" but please check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link passed local test.

Copy link
Collaborator

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger, swopebe

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swopebe swopebe merged commit 6f4d477 into 2.12_stage Dec 3, 2024
1 of 2 checks passed
@swopebe swopebe deleted the swope-build branch December 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants