Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://issues.redhat.com/browse/ACM-15155 #7281
https://issues.redhat.com/browse/ACM-15155 #7281
Changes from 2 commits
8ad2638
0a0b82b
195115e
36263ab
bf17986
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's reduce the same robotic language "Fixes an issue where" so not each of these sound the same. Also are these actual code elements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We switch tense here at times. Please see previous release notes. Not sure if you want present or past here.
..is stuck in a type of
progressing
state. (really weird line, what are we trying to say here?)Stuck in the
progressing
status (or stage)... is usually how tech writers would word a status.Again, you have to rewrite most of what you get to make it understandable to the user...and that means we have to have some level of understanding about what we are trying to say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check in the issue, but I think we are trying to say that the
cluster-proxy-addon
resource(??) is stuck in theProgressing
state. (or status, usually starts with a capital letter but I could be wrong--although that would be weird to have it lower case)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Brandi! So, I think the revision works, let me know what you think.
Reading the Jira, it says the state is "progressing... mca and work configs mismatch"
I've never seen a state that long nor a state with ellipses in it. Anyway, I think
Progressing
captures what it means and the JIra can give the user more detail, but let me know if you think the rewrite fixes your concern with it being confusing.