https://issues.redhat.com/browse/ACM-15155 #7281
Conversation
|
|
||
| * Fixes an issue where the `Detach clusters` action would destroy hosted clusters. (https://issues.redhat.com/browse/ACM-15018[ACM-15018]) | ||
|
|
||
| * Fixes an issue where the `Spokes` continue to display in Discovery UI. (https://issues.redhat.com/browse/ACM-15010[ACM-15010]) |
There was a problem hiding this comment.
We don't use UI in ACM, we use "console" and we also don't write Spokes, these are managed clusters. The developers will write this, we have to know to change the terms.
There was a problem hiding this comment.
I really don't understand this, because do we not want managed clusters to show on the Discovery page (?). Let's check on that by looking deeper at the developer bug.
Fixes problem with managed clusters erroneously displaying on the Discovery page in the console. (???)
But again, let's see what we are trying to say here because is the error that they appear or that they were removed and they appear. If that is the case, we need to specify.
|
|
||
| * Fixes an issue where the `cluster-proxy-addon` is stuck in a type of `progressing` state. (https://issues.redhat.com/browse/ACM-14863[ACM-14863]) | ||
|
|
||
|
|
There was a problem hiding this comment.
Let's reduce the same robotic language "Fixes an issue where" so not each of these sound the same. Also are these actual code elements?
There was a problem hiding this comment.
We switch tense here at times. Please see previous release notes. Not sure if you want present or past here.
..is stuck in a type of progressing state. (really weird line, what are we trying to say here?)
Stuck in the progressing status (or stage)... is usually how tech writers would word a status.
Again, you have to rewrite most of what you get to make it understandable to the user...and that means we have to have some level of understanding about what we are trying to say.
There was a problem hiding this comment.
Check in the issue, but I think we are trying to say that the cluster-proxy-addon resource(??) is stuck in the Progressing state. (or status, usually starts with a capital letter but I could be wrong--although that would be weird to have it lower case)
There was a problem hiding this comment.
Thanks, Brandi! So, I think the revision works, let me know what you think.
Reading the Jira, it says the state is "progressing... mca and work configs mismatch"
I've never seen a state that long nor a state with ellipses in it. Anyway, I think Progressing captures what it means and the JIra can give the user more detail, but let me know if you think the rewrite fixes your concern with it being confusing.
|
|
||
| * Fixes an issue where the `Detach clusters` action would destroy hosted clusters. (https://issues.redhat.com/browse/ACM-15018[ACM-15018]) | ||
|
|
||
| * Fixes an issue where the `Spokes` continue to display in Discovery UI. (https://issues.redhat.com/browse/ACM-15010[ACM-15010]) |
There was a problem hiding this comment.
DO we mean discovery page?
There was a problem hiding this comment.
see above comment on this; it's confusing to me :-)
|
|
||
| * Delivers updates to one or more product container images. | ||
|
|
||
| * Fixes an issue where the *Clear all filters* button does not work. (https://issues.redhat.com/browse/ACM-15277[ACM-15277]) |
There was a problem hiding this comment.
Fixes an error with the Clear all filters button. (An example of re-wording)
Co-authored-by: Mikela Jackson <[email protected]>
Co-authored-by: Mikela Jackson <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jc-berger, swopebe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: swope <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
/approve |
See Jira: https://issues.redhat.com/browse/ACM-15155