Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a little more detail on demo usage #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,7 @@ For more details, see [Adding Package Dependencies to Your App](https://develope
<img src="/Docs/Images/BetterSafariViewDemo-watchOS.png" width="275">
</p>

You can see how it works on each platform and compare it with the other naive implementations in the demo project. Check out the demo app by opening BetterSafariView.xcworkspace.

You can see how it works on each platform and compare it with the other naive implementations in the demo project. Check out the demo app by opening BetterSafariViewDemo.xcodeproj, adding the BetterSafariView package dependency in Xcode (`File` > `Add Packages` > `Add Local` > select the root folder of BetterSafariView), and finally run build.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can see how it works on each platform and compare it with the other naive implementations in the demo project. Check out the demo app by opening BetterSafariViewDemo.xcodeproj, adding the BetterSafariView package dependency in Xcode (`File` > `Add Packages` > `Add Local` > select the root folder of BetterSafariView), and finally run build.
You can see how it works on each platform and compare it with the other naive implementations in the demo project. Check out the demo app by opening BetterSafariViewDemo.xcworkspace adding the BetterSafariView package dependency in Xcode (`File` > `Add Packages` > `Add Local` > select the root folder of BetterSafariView > Select Build Targets to add to), and finally run build.

This should remain .xcworkspace because that is the only file available. Devs will also need to select a build target as shown here Screenshot 2024-01-01 at 13 38 22

**NOTE:** This demo project is available for iOS 14.0+, macOS 11.0+, and watchOS 7.0+, while the package is compatible with iOS 13.0+, macOS 10.15+, and watchOS 6.2+.

## License
Expand Down