add a little more detail on demo usage #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokj4ck
reviewed
Jan 1, 2024
| @@ -329,8 +329,7 @@ For more details, see [Adding Package Dependencies to Your App](https://develope | |||
| <img src="/Docs/Images/BetterSafariViewDemo-watchOS.png" width="275"> | |||
| </p> | |||
|
|
|||
| You can see how it works on each platform and compare it with the other naive implementations in the demo project. Check out the demo app by opening BetterSafariView.xcworkspace. | |||
|
|
|||
| You can see how it works on each platform and compare it with the other naive implementations in the demo project. Check out the demo app by opening BetterSafariViewDemo.xcodeproj, adding the BetterSafariView package dependency in Xcode (`File` > `Add Packages` > `Add Local` > select the root folder of BetterSafariView), and finally run build. | |||
There was a problem hiding this comment.
Suggested change
| You can see how it works on each platform and compare it with the other naive implementations in the demo project. Check out the demo app by opening BetterSafariViewDemo.xcodeproj, adding the BetterSafariView package dependency in Xcode (`File` > `Add Packages` > `Add Local` > select the root folder of BetterSafariView), and finally run build. | |
| You can see how it works on each platform and compare it with the other naive implementations in the demo project. Check out the demo app by opening BetterSafariViewDemo.xcworkspace adding the BetterSafariView package dependency in Xcode (`File` > `Add Packages` > `Add Local` > select the root folder of BetterSafariView > Select Build Targets to add to), and finally run build. |
This should remain .xcworkspace because that is the only file available. Devs will also need to select a build target as shown here 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.